Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong location icon and page info bubble of brave page #3411

Closed
simonhong opened this issue Feb 19, 2019 · 2 comments · Fixed by brave/brave-core#2024
Closed

Wrong location icon and page info bubble of brave page #3411

simonhong opened this issue Feb 19, 2019 · 2 comments · Fixed by brave/brave-core#2024
Assignees
@bridiver
Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release/blocking release-notes/exclude
Milestone
0.62.x - Release ...

Comments

@simonhong
Copy link
Member

simonhong commented Feb 19, 2019 •
edited
Loading

screen shot 2019-02-19 at 9 58 17 am

This should be like below.
screen shot 2019-02-19 at 9 59 49 am

This is regression of brave/brave-core#1385 and only reproducible on master and latest 0.62.x branch.
Reproducible on dev branch and not on released stable/beta.

STR

  1. Load brave url like brave://settings
  2. Check location icon and proper page info bubble is used
@simonhong simonhong added this to the 0.62.x - Dev milestone Feb 19, 2019
@simonhong simonhong self-assigned this Feb 19, 2019
@simonhong simonhong mentioned this issue Feb 19, 2019
Closed
18 tasks
@srirambv srirambv added about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages QA/Yes release-notes/exclude labels Feb 25, 2019
@fmarier
Copy link
Member

fmarier commented Mar 1, 2019

This also affects brave/brave-core#1630.

@simonhong simonhong assigned bridiver and unassigned simonhong Mar 1, 2019
@rebron rebron added release/blocking priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Mar 19, 2019
@bridiver bridiver mentioned this issue Mar 21, 2019
Merged
19 tasks
bridiver added a commit to brave/brave-core that referenced this issue Mar 21, 2019
@bridiver
only use brave:// url for display purposes because chrome does some s…
2f55d43 
…ecurity checks based on the virtual url

fix brave/brave-browser#3411
@srirambv srirambv mentioned this issue Mar 22, 2019
Closed
@btlechowski
Copy link

btlechowski commented Mar 26, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.62.42 Chromium: 73.0.3683.86 (Official Build) beta (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Windows 10 OS Build 17134.523

Used test plan from brave/brave-core#2024

Examples:
image
image
image
image

Verification passed on Ubuntu 18.04 LTS

Brave 0.62.45 Chromium: 73.0.3683.86 (Official Build) beta(64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Linux
JavaScript V8 7.3.492.25

image

Verified passed with

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Mac OS X

Screen Shot 2019-04-01 at 1 00 20 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
8 participants
@bridiver @fmarier @petemill @rebron @simonhong @srirambv @LaurenWags @btlechowski