Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Leo and Playlist icons in Private, Private with Tor, and Guest profile windows #34518

Closed
stephendonner opened this issue Nov 23, 2023 · 4 comments · Fixed by brave/brave-core#21116
Closed

Hide Leo and Playlist icons in Private, Private with Tor, and Guest profile windows #34518

stephendonner opened this issue Nov 23, 2023 · 4 comments · Fixed by brave/brave-core#21116
Assignees
@simonhong
Labels
enhancement feature/user-interface All UI related OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@stephendonner
Copy link

stephendonner commented Nov 23, 2023 •
edited
Loading

Description

Leo and Playlist icons should be hidden, not just disabled in Private, Private with Tor, and Guest profile windows

Steps to Reproduce

  1. install 1.62.76
  2. launch Brave
  3. open a New Private Window
  4. open a New Private Window with Tor
  5. open a Guest profile window
  6. look at the Leo and Playlist (when enabled) icons

Actual result:

Leo and Playlist icons are disabled

Private Window with Tor Private Window Guest profile
Screenshot 2023-11-23 at 10 56 23 AM Screenshot 2023-11-23 at 10 57 09 AM Screenshot 2023-11-23 at 10 56 43 AM

Expected result:

The disabled Leo and Playlist icons should be hidden/removed while unavailable in these window types

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.62.76 Chromium: 119.0.6045.163 (Official Build) nightly (x86_64)
-- | --
Revision | 8b454b7ea4b543d9f66aeb6c18940a351f0c4d10
OS | macOS Version 14.2 (Build 23C5047e)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

/cc @simonhong @rebron @brave/qa-team
@simonhong simonhong self-assigned this Nov 25, 2023
simonhong added a commit to brave/brave-core that referenced this issue Nov 25, 2023
@simonhong
Hide sidebar items instead of disabling
8db0f45 
fix brave/brave-browser#34518

Provide profile specific default items list to sidebar service.
With this normal/private/guest window can have different set of
default items.
@simonhong simonhong mentioned this issue Nov 25, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Nov 28, 2023
@simonhong
Hide sidebar items instead of disabling
17d920d 
fix brave/brave-browser#34518

Provide profile specific default items list to sidebar service.
With this normal/private/guest window can have different set of
default items.
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 28, 2023
@stephendonner
Copy link
Author

stephendonner commented Nov 30, 2023 •
edited
Loading

Verified PASSED using

Brave | 1.63.1 Chromium: 120.0.6099.35 (Official Build) nightly (x86_64)
-- | --
Revision | 96919ee80aa1034307f2bde0963150c45193c99e
OS | macOS Version 11.7.10 (Build 20G1427)

Followed my original steps to reproduce

Confirmed Leo and Playlist icons were hidden in Private, Private with Tor, and Guest-profile windows

... but were still available in normal window/tab types

example example example normal window
Screen Shot 2023-11-30 at 4 23 43 AM Screen Shot 2023-11-30 at 4 24 50 AM Screen Shot 2023-11-30 at 4 25 11 AM Screen Shot 2023-11-30 at 4 42 13 AM

@LaurenWags
Copy link
Member

Removed QA Pass-macOS label as this was tested on 1.63.x but should be tested on 1.62.x per the milestone on the issue.

@stephendonner
Copy link
Author

Removed QA Pass-macOS label as this was tested on 1.63.x but should be tested on 1.62.x per the milestone on the issue.

Thanks, yes - redressing and retesting this on 1.62.x now (train migrations!)

@stephendonner
Copy link
Author

Verified PASSED using

Brave | 1.62.93 Chromium: 120.0.6099.35 (Official Build) beta (x86_64)
-- | --
Revision | 2032da61e85b8d826ab474ee36fee9a9cee09907
OS | macOS Version 11.7.10 (Build 20G1427)

Followed my original steps to reproduce

Confirmed Leo and Playlist icons were hidden in Private, Private with Tor, and Guest-profile windows

... but were still available in normal window/tab types

example example example example
Screen Shot 2023-11-30 at 4 53 13 AM Screen Shot 2023-11-30 at 4 53 38 AM Screen Shot 2023-11-30 at 4 54 06 AM Screen Shot 2023-11-30 at 5 12 19 AM

@rebron rebron changed the title Leo and Playlist icons should be hidden, not just disabled in Private, Private with Tor, and Guest profile windows Hide Leo and Playlist icons instead of disable in Private, Private with Tor, and Guest profile windows Jan 23, 2024
@rebron rebron changed the title Hide Leo and Playlist icons instead of disable in Private, Private with Tor, and Guest profile windows Hide Leo and Playlist icons in Private, Private with Tor, and Guest profile windows Jan 23, 2024
@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
enhancement feature/user-interface All UI related OS/Desktop QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

Hide sidebar items instead of disabling brave/brave-core
4 participants
@stephendonner @simonhong @LaurenWags @brave-builds