Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Klaviyo's user identifier from URLs #34578

Closed
fmarier opened this issue Nov 28, 2023 · 2 comments · Fixed by brave/brave-core#21140
Closed

Remove Klaviyo's user identifier from URLs #34578

fmarier opened this issue Nov 28, 2023 · 2 comments · Fixed by brave/brave-core#21140
Assignees
@fmarier
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Nov 28, 2023

Klaviyo uses the _kx parameter to track individual users clicking on email links.
@fmarier fmarier added OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Nov 28, 2023
@fmarier fmarier self-assigned this Nov 28, 2023
fmarier added a commit to brave/brave-core that referenced this issue Nov 28, 2023
@fmarier
Filter out Klaviyo's user identifier from URLs (fixes brave/brave-bro…
01b79ea 
…wser#34578)
@fmarier fmarier added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/include labels Nov 28, 2023
@fmarier fmarier mentioned this issue Nov 28, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.62.x - Nightly milestone Nov 29, 2023
@stephendonner
Copy link

Verified PASSED using

Brave | 1.62.93 Chromium: 120.0.6099.35 (Official Build) beta (x86_64)
-- | --
Revision | 2032da61e85b8d826ab474ee36fee9a9cee09907
OS | macOS Version 14.2 (Build 23C5055b)

Steps:

  1. installed 1.62.93
  2. launched Brave
  3. loaded https://brave.com/?foo=yes&_kx=1234
  4. checked developer tools' Network tab

Confirmed only https://brave.com/?foo=yes was loaded

Screenshot 2023-12-02 at 3 13 20 AM

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 20, 2023
@hffvld
Copy link
Contributor

hffvld commented Dec 21, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP11.231020.013.A1 release-keys
Brave build: 1.61.100
Chromium: 120.0.6099.62 (Official Build) (64-bit)

STEPS:

  1. Launch Brave
  2. Go to https://brave.com/?foo=yes&_kx=1234
    checked developer tools' Network tab

ACTUAL RESULTS:

  • Verified that only https://brave.com/?foo=yes was loaded
1 2 3
1 2 3

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 21, 2023
@rebron rebron changed the title Filter out Klaviyo's user identifier from URLs Remove Klaviyo's user identifier from URLs Jan 23, 2024
@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
@kjozwiak kjozwiak mentioned this issue Jan 26, 2024
Closed
lyubomyr-shaydariv added a commit to lyubomyr-shaydariv/uu-webext that referenced this issue Jun 15, 2024
@lyubomyr-shaydariv
https://github.com/brave/brave-browser/issues/34578
849ce77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/query-filter QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/include
Projects
Security & Privacy
Status: Completed
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

Filter out Klaviyo's user identifier from URLs brave/brave-core
4 participants
@fmarier @stephendonner @brave-builds @hffvld