Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global shields settings #348

Closed
srirambv opened this issue Jun 15, 2018 · 1 comment
Closed

Global shields settings #348

srirambv opened this issue Jun 15, 2018 · 1 comment
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 15, 2018 •
edited
Loading

image

Should also provide an option to clear all saved site settings. Currently settings changed in shields can't be cleared and just show up as a read only option under global settings.

May be related to #232

cc: @bradleyrichter
@srirambv srirambv added feature/shields The overall Shields feature in Brave. feature/global-settings Settings at browser level independent of shields settings design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Jun 15, 2018
@srirambv srirambv added this to the Backlog milestone Jun 15, 2018
@srirambv srirambv mentioned this issue Aug 10, 2018
Closed
7 tasks
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Sep 24, 2018
Closed
@bsclifton
Copy link
Member

Implemented with #1100
screen shot 2018-10-30 at 1 01 09 pm

We do have an issue to restyle this content, which is captured with #606

@bsclifton bsclifton modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Oct 30, 2018
@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Oct 30, 2018
@kjozwiak kjozwiak removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/global-settings Settings at browser level independent of shields settings feature/shields The overall Shields feature in Brave. labels Nov 6, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bbondy @kjozwiak @bsclifton @srirambv