Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default Brave shield settings #1100

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Add default Brave shield settings #1100

merged 1 commit into from
Sep 26, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 12, 2018 •
edited
Loading

Requires:
Fix #1288

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bbondy bbondy changed the title WIP: Default Brave shields Add default Brave shield settings Sep 26, 2018
@bbondy bbondy mentioned this pull request Sep 26, 2018
Merged
11 tasks
emerick
emerick approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit cdc0543 into master Sep 26, 2018
bbondy added a commit that referenced this pull request Sep 26, 2018
@bbondy
Merge pull request #1100 from brave/default-brave-shields
ffb4bcf 
Add default Brave shield settings
@bbondy
Copy link
Member Author

bbondy commented Sep 26, 2018

master cdc0543
0.55.x ffb4bcf

@bsclifton bsclifton deleted the default-brave-shields branch September 26, 2018 20:34
@bsclifton bsclifton mentioned this pull request Oct 30, 2018
Closed
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @emerick