Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads Panel in 0.61x should have Ads Coming Soon #3500

Closed
mandar-brave opened this issue Feb 26, 2019 · 3 comments
Closed

Ads Panel in 0.61x should have Ads Coming Soon #3500

mandar-brave opened this issue Feb 26, 2019 · 3 comments

Comments

@mandar-brave
Copy link

mandar-brave commented Feb 26, 2019

Please see issue created by @LaurenWags for 0.60 for details below.
Status quo for 0.61 - #3421

Original plan is here: #3141

cc @jsecretan @bbondy @rebron

@mandar-brave mandar-brave added feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 26, 2019
@ryanml ryanml added this to the 0.61.x - Beta milestone Feb 27, 2019
@jsecretan
Copy link

Ads will finally go to production on 0.63.

@ryanml
Copy link
Contributor

ryanml commented Mar 4, 2019

This was done via: brave/brave-core#1793

@ryanml ryanml closed this as completed Mar 4, 2019
@srirambv
Copy link
Contributor

srirambv commented Mar 5, 2019

Verification passed on

Brave 0.61.46 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux
  • Can't test with old profile with ads enabled on Linux as its still not supported
    image

Verification passed on

Brave 0.61.46 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

image

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.61.48 Chromium: 73.0.3683.56 (Official Build) beta(64-bit)
Revision 303af44e2f2948869279f120021c778855d76ead-refs/branch-heads/3683@{#653}
OS Mac OS X

screen shot 2019-03-07 at 12 12 53 pm

  • Went through the test plan outlined under Disables Ads on 0.61 brave-core#1793
  • Launched using --enable-logging=stderr --vmodule=brave_ads=3 --log-level=0 using a brand new profile and ensured there was no ads logging
  • Launched using --enable-logging=stderr --vmodule=brave_ads=3 --log-level=0 using a profile that already had ads enabled and ensured that there wasn't any ad logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants