Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads panel in 0.62x should have Ads Coming Soon text #3900

Closed
rebron opened this issue Mar 26, 2019 · 3 comments
Closed

Ads panel in 0.62x should have Ads Coming Soon text #3900

rebron opened this issue Mar 26, 2019 · 3 comments

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 26, 2019

Please see 60.x issue created by @LaurenWags for details.
0.60.x -> #3421
0.61.x -> (same as well) #3500

cc: @jsecretan @bbondy @mandar-brave

Expected result:

same as 0.61.x
screen shot 2019-02-19 at 1 55 52 pm

@rebron rebron added release-notes/exclude priority/P2 A bad problem. We might uplift this to the next planned release. release/blocking feature/ads feature/rewards labels Mar 26, 2019
@rebron rebron added this to the 0.62.x - Beta milestone Mar 26, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Mar 26, 2019

Thanks for getting this filed @rebron 👍 Currently looks as follows when using 0.62.41 Chromium: 73.0.3683.86:

Screen Shot 2019-03-26 at 6 12 22 PM

As @rebron mentioned above, should look the same as it does on 0.61.52 Chromium: 73.0.3683.86.

ryanml added a commit to brave/brave-core that referenced this issue Mar 26, 2019
@ryanml
Copy link
Contributor

ryanml commented Mar 31, 2019

Closed via: brave/brave-core#2082

@ryanml ryanml closed this as completed Mar 31, 2019
@bbondy bbondy added the QA/Yes label Mar 31, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 1, 2019

Verification passed on

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Windows 10 OS Build 17134.523
  • Verified the description mentioned in the issue

image

Verified passed with

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Mac OS X

Screen Shot 2019-04-01 at 9 55 55 AM

  • Verified that files in the Default/ads_service directory are not created or updated when Ads are turned off
  • Verified launching with /Applications/Brave\ Browser.app/Contents/MacOS/Brave\ Browser --enable-logging=stderr --vmodule=brave_ads=3 --log-level=0, enabling Rewards, and browsing did not show any AdService Event Log messages in terminal
  • Verified turning Rewards off and browsing still did not show any AdService Event Log messages in terminal
  • Verified closing/relaunching Brave, enabling Rewards again, and browsing did not show any AdService Event Log messages in terminal
  • Verified to way to toggle Ads on in UI
  • Verified no Ad notifications were presented while browsing

Verification passed on

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants