Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not add a page to top sites #3805

Closed
btlechowski opened this issue Mar 20, 2019 · 4 comments · Fixed by brave/brave-core#2037
Closed

Can not add a page to top sites #3805

btlechowski opened this issue Mar 20, 2019 · 4 comments · Fixed by brave/brave-core#2037
Assignees
@cezaraugusto
Labels
feature/new-tab priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release/blocking release-notes/exclude
Milestone
0.62.x - Release ...

Comments

@btlechowski
Copy link

btlechowski commented Mar 20, 2019 •
edited
Loading

Top sites are always empty on clean profile

Steps to Reproduce

  1. Clean profile
  2. Add page to top sites (I used youtube.com, interia.pl)

Actual result:

page in not added to top sites
Top sites are always empty

Possible regression due to #3710

image

Expected result:

page is added to top sites

image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Reproduced on

Brave 0.62.32 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523
Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523
Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Ubuntu 18.04 LTS

Not reproducible on

Brave 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

cc @brave/legacy_qa @cezaraugusto
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Mar 20, 2019
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 20, 2019 •
edited
Loading

Reproducible on Windows 10 x64 - 0.63.14

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

@LaurenWags
Copy link
Member

LaurenWags commented Mar 20, 2019 •
edited
Loading

Reproduced on macOS Beta and Dev

Brave 0.62.33 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X
Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

@kjozwiak
Copy link
Member

@rebron we should probably fix this for 0.62.x as it's a regressions. Top sites aren't being added onto the NTP. Labelling this as P2 for now. If you feel differently, please re-assign priority.

@kjozwiak kjozwiak added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 20, 2019
@cezaraugusto cezaraugusto self-assigned this Mar 21, 2019
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Mar 21, 2019
Closed
@cezaraugusto cezaraugusto mentioned this issue Mar 22, 2019
Merged
This was referenced Mar 22, 2019
Merged
Merged
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 1, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Windows 10 OS Build 17134.523
  • Verified the STR mentioned in the description

image

Verification passed on

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Linux

Used STR from the description
image

Verified passed with

Brave 0.62.49 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Mac OS X
  • Verified STR from description
    Screen Shot 2019-04-01 at 10 58 26 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/new-tab priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
0.62.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

block default chrome url in topsites list brave/brave-core
6 participants
@kjozwiak @cezaraugusto @rebron @LaurenWags @btlechowski @GeetaSarvadnya