Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google extension Office Editing for Docs, Sheets & Slides is not working #3968

Closed
GeetaSarvadnya opened this issue Apr 2, 2019 · 28 comments
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 2, 2019

Description

Google extension Office Editing for Docs, Sheets & Slides is not working
https://chrome.google.com/webstore/detail/office-editing-for-docs-s/gbkeegbaiigmenfmjfclcdgdpimamgkj

Steps to Reproduce

  1. Open brave 0.61.52
  2. Install the extension Office Editing for Docs, Sheets & Slides from CWS
  3. try to open Docs, excel or slides

Actual result:

Word, exce and slides are not loaded, page is empty.
image

Office extension issue

Console Error:

image

Expected result:

The extension should load word, excel, and slides

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.61.52 Chromium: 73.0.3683.86 (Official Build) (64-bit)
Revision f9b0bec6063ea50ce2b71f5b9abbae7beee319a6-refs/branch-heads/3683@{#858}
OS Windows 10 OS Build 17134.523

Reproducible on current release: Yes

  • Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

The issue is reported by the community
https://community.brave.com/t/not-working-google-extension-for-office-editing-for-docs-sheets-slides/50968

@brave/legacy_qa @bbondy

@GeetaSarvadnya GeetaSarvadnya added bug feature/extensions QA/Yes webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Apr 2, 2019
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 5, 2019
@srirambv
Copy link
Contributor

@benjaminrohe
Copy link

+1 this is mission critical to use BRAVE as a work browser.

any estimate when this issue is resolved?

@bsclifton
Copy link
Member

Looks like the extension is using Google Analytics (and possibly other 3rd party scripts)

Also seeing (in the logs) reference to Nacl which we don't support (it's being phased out). If this is the blocker, there should be a newer version of the extension coming out soon as Web Assembly

Blog with more info (if this does use NaCl / Native Client)
https://developer.chrome.com/native-client/migration

@benjaminrohe
Copy link

benjaminrohe commented Jul 23, 2019 via email

@mishaley
Copy link

Agreed, I also need this to fully move over to Brave.

@benlc
Copy link

benlc commented Oct 29, 2019

+1 would love a fix for this

@bblaha
Copy link

bblaha commented Nov 6, 2019

+1 absolutely essential to me

@dylan1114
Copy link

+1 I hope this gets fixed, then the browser is perfect for me.

@webjive
Copy link

webjive commented Nov 13, 2019

Ditto!! Would love for this to work with Brave or someone to fork it and get it working.

@bkkarki21
Copy link

The only reason I have chrome installed (along with Brave) is that this extension does not work in Brave.

@UtahJonF
Copy link

UtahJonF commented Jan 3, 2020

+1 This keeps me having both Brave and Chrome installed.

@rebron rebron added the google label Jan 9, 2020
@adam-hurwitz
Copy link

Gdocs is working offline for me which appears to be a new update for Brave!

Version: 1.3.118 Chromium: 80.0.3987.116 (Official Build) (64-bit)

@bsclifton
Copy link
Member

Thanks for the update, @AdamSHurwitz!

I tried the steps specified in https://community.brave.com/t/not-working-google-extension-for-office-editing-for-docs-sheets-slides/50968 (ex: going to extension menu, picking New Spreadsheet) and it doesn't work for me ☹️ I suspect there is still a problem here

@adam-hurwitz
Copy link

@bsclifton, This is the flow that is working for me:

  1. Turn Wi-Fi off.
  2. Go to https://drive.google.com/drive/my-drive
  3. Select the '+ New' button in the top left menu column.
  4. Select either a doc/sheet/slide/etc.

@rodrigoswz
Copy link

No news for fix this issue? This extension works perfectly on others Chromium browsers like Chrome, Edge, Vivaldi...

Only on Brave which is my favorite that doesn't 😟

@webjive
Copy link

webjive commented Mar 23, 2020

We've given up on Brave and moved back to Chrome.

@adam-hurwitz
Copy link

adam-hurwitz commented Mar 23, 2020

@webjive, I'm back to Chrome as of this week as well. The game changer for me is when my laptop had to go to the repair shop and rediscovering how Brave does not sync 'Other search engines' and custom shortcut/hot keys. Chrome allows the syncing of the above which is great for switching between devices seamlessly.

I'm looking forward to trying Brave again in the future. 🦁🚀

@UtahJonF
Copy link

I'm also back to Chrome starting this week. Between all of the sites that don't work (even with shields down), bookmark sync, and offline google docs, I'm exhausted fighting with this thing. The parts I do like are the built in shields up/down idea and the incognito with Tor option. I'm sure this will all get fixed or Chrome will build out the parts that work. Best of luck.

@DarkoMir
Copy link

I found that if you use google docs format, extension works flawless, while if you use xls(x), doc(x) ecc then blank page

@simonhong simonhong self-assigned this May 26, 2020
@simonhong
Copy link
Member

This extension is based on nacl and we don't ship it.
@rebron @bsclifton maybe this issue should be won't fix?

@rebron rebron assigned rebron and Brave-Matt and unassigned simonhong May 26, 2020
@bsclifton
Copy link
Member

bsclifton commented May 26, 2020

nacl (Native Client) supposed to be deprecated Q4 2019
https://developer.chrome.com/native-client/migration

So I agree - this might be a wontfix. Maybe we can open an issue with the extension devs?

@fmarier
Copy link
Member

fmarier commented May 26, 2020

The official Google extension I use for offline editing of Google Docs does work fine in Brave, but it appears to be a different one: https://chrome.google.com/webstore/detail/google-docs-offline/ghbmnnjooekpmoecnnnilnnbdlolhkhi

@bsclifton
Copy link
Member

cc: @DarkoMir @UtahJonF @AdamSHurwitz @webjive @rodrigoswz @bjkarki @dylan1114 @bblaha @benlc @mishaley @benjaminrohe

Would you all be able to try the other extension that @fmarier shared above?
https://chrome.google.com/webstore/detail/google-docs-offline/ghbmnnjooekpmoecnnnilnnbdlolhkhi

I'll see if I'm able to reach Google support and will report back findings

@rodrigoswz
Copy link

rodrigoswz commented May 26, 2020

In my case, I just need this extension to open documents directly from the browser. Without the need to download them.

Try this link for example.
In Brave, with the extension of this issue, you will have a white screen exactly as reported.
But if you try it on Edge or Chrome, it will open perfectly as expected.

Here's the proof

@bsclifton
Copy link
Member

@rodrigoswz correct - because Chrome and Edge are compiling using NaCl (native client) and with Brave we don't. It was supposed to be deprecated end of 2019, but appears it hasn't been

If you download https://chrome.google.com/webstore/detail/google-docs-offline/ghbmnnjooekpmoecnnnilnnbdlolhkhi instead (and remove https://chrome.google.com/webstore/detail/office-editing-for-docs-s/gbkeegbaiigmenfmjfclcdgdpimamgkj), we suspect it should work perfectly for you

Please let us know 😄

@rodrigoswz
Copy link

@bsclifton yes, I tried https://chrome.google.com/webstore/detail/google-docs-offline/ghbmnnjooekpmoecnnnilnnbdlolhkhi on Brave (without https://chrome.google.com/webstore/detail/office-editing-for-docs-s/gbkeegbaiigmenfmjfclcdgdpimamgkj) but unfortunately the file is directly downloaded instead of open in the browser.

I tested this with the link I sent as an example in my previous comment.

@rebron
Copy link
Collaborator

rebron commented Oct 14, 2020

Closing and marking as wontfix per #3968 (comment) and https://developer.chrome.com/native-client/migration#p-nacl-deprecation-announcements
This is a nacl based extension and won't be supported in the future.

@rebron rebron closed this as completed Oct 14, 2020
@rebron rebron added closed/wontfix and removed QA/Yes priority/P2 A bad problem. We might uplift this to the next planned release. webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Oct 14, 2020
@TheNerdMan
Copy link

I understand that this has been closed due to nacl deprecation, but it is a huge flaw not being able to support official google extensions. Especially ones that seem to have as much traction as this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests