Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "Copy clean link" listed first in the share menu #40614

Closed
6 tasks
fmarier opened this issue Aug 22, 2024 · 1 comment · Fixed by brave/brave-core#25356
Closed
6 tasks

Make "Copy clean link" listed first in the share menu #40614

fmarier opened this issue Aug 22, 2024 · 1 comment · Fixed by brave/brave-core#25356
Assignees
@boocmp
Labels
copy-clean-link OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.71.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Aug 22, 2024

Description

Change the order of the first two entries in the share menu on desktop.

Steps to reproduce

  1. Click on share button in the URL bar.

Actual result

Screenshot from 2024-08-22 12-18-22

Expected result

It should be:

  • Copy clean link
  • Copy
  • Screenshot
  • ...

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave	1.70.80 Chromium: 128.0.6613.27 (Official Build) beta (64-bit) 
Revision	6ead335dec3d127f8c0771502638567481f41080
OS	Linux

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@rebron rebron added QA/Yes release-notes/exclude priority/P4 Planned work. We expect to get to it "soon". labels Aug 23, 2024
@boocmp boocmp mentioned this issue Aug 28, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Aug 29, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.71.96 Chromium: 129.0.6668.70 (Official Build) beta (64-bit)
-- | --
Revision | 6dc1837bd07e6dacd8b6b7b5d9f27e7bb09b5eb5
OS | Windows 11 Version 23H2 (Build 22631.4169)

Verified using STR from #40614 (comment)

Confirmed the order. Copy clean link shown first and Copy link is below in the share menu and both worked as expected

image

@rebron rebron changed the title Make "Copy clean link" first in the share menu Make "Copy clean link" listed first in the share menu Oct 8, 2024
@LaurenWags LaurenWags mentioned this issue Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boocmp boocmp

Labels
copy-clean-link OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
Settings
Status: Completed
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

Changed order of Copy & Copy clean items in the Sharing hub. brave/brave-core
5 participants
@fmarier @rebron @brave-builds @boocmp @MadhaviSeelam