Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip srsltid from all URLs #40912

Closed
fmarier opened this issue Sep 6, 2024 · 2 comments · Fixed by brave/brave-core#25478
Closed

Strip srsltid from all URLs #40912

fmarier opened this issue Sep 6, 2024 · 2 comments · Fixed by brave/brave-core#25478
Assignees
@fmarier
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality privacy/query-filter QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.71.x - Release

Comments

@fmarier
Copy link
Member

fmarier commented Sep 6, 2024 •
edited
Loading

Description

Google recently started to add a new parameter to organic search results via the auto-tagging feature of the Merchant Center. It is used for conversion reporting.

We should remove srsltd from URLs since this identifier is unique to each user:

The result id is created at the time of an impression. If a customer clicks the same free listings again, the same result id will be used.
@fmarier fmarier self-assigned this Sep 6, 2024
fmarier added a commit to brave/brave-core that referenced this issue Sep 6, 2024
@fmarier
Remove Google's srsltid parameter from URLs (fixes brave/brave-browse…
0ce139c 
…r#40912)
@fmarier fmarier added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Sep 6, 2024
@fmarier fmarier mentioned this issue Sep 6, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Sep 6, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 19, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.71.90 Chromium: 129.0.6668.59 (Official Build) beta (64-bit)
-- | --
Revision | 1f5f0d1b8a45a4c60a78c15df081751e39184b97
OS | Windows 11 Version 23H2 (Build 22631.4169)

Reproduced the issue in 1.70.117

Confirmed srsltid=12345 parameter is shown in the URL bar

image

  1. Installed 1.71.90
  2. launched Brave
  3. opened brave://settings/shields in a new tab
  4. verified Trackers & ads blocking shows Standard
  5. visited https://brave.com/?srsltid=12345

Confirmed that the URL bar shows https://brave.com/ and srsltid=12345 parameter was stripped off.

example example
image image

@srirambv
Copy link
Contributor

srirambv commented Oct 8, 2024

Verification passed on Google Pixel 8 with Android 14 running 1.71.104 x64 Beta build

  • Verified steps from issue description
  • Verified setting Shields to Block trackers and ads (Standard) and visiting https://brave.com/?srsltid=12345`, redirects to https://brave.com and removes ?srsltid=12345
40912.mp4

@LaurenWags LaurenWags mentioned this issue Oct 16, 2024
Closed
@hffvld hffvld mentioned this issue Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality privacy/query-filter QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Security & Privacy
Status: Completed
Milestone
1.71.x - Release
Development

Successfully merging a pull request may close this issue.

Remove Google's srsltid parameter from URLs brave/brave-core
4 participants
@fmarier @srirambv @brave-builds @MadhaviSeelam