Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rounded Corners]: In rounded corners mode, there's no separation between the web_contents and the browser chrome #41313

Closed
fallaciousreasoning opened this issue Oct 1, 2024 · 2 comments · Fixed by brave/brave-core#25738
Assignees
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Milestone

Comments

@fallaciousreasoning
Copy link

  1. In light mode, with brave://flags/#brave-web-view-rounded-corners enabled
  2. Navigate to https://google.com

Expected:
There is some kind of separation between the webcontents and the browser chrome

Actual:
There is not:

image

@simonhong
Copy link
Member

simonhong commented Oct 1, 2024

I can see space between web contents and sidebar in any theme.
image
image

When vertical tab is enabled, there is no left-side space of web contents. I think this is the issue.
Same issue when vertical tab is on right side.
image
image

@fallaciousreasoning
Copy link
Author

@simonhong yeah you're right - the issue was there were no margins around the webcontents - I've added them in brave/brave-core#25738. Mind taking a look and seeing what you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants