[Rounded Corners]: Fix WebContents shadow in light mode #25738

fallaciousreasoning · 2024-10-01T01:49:25Z

Resolves brave/brave-browser#41313

Before:

After:

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

fallaciousreasoning · 2024-10-01T01:50:05Z

Hey @simonhong and @zenparsing I'm not sure if this is the best approach as it makes everything very interconnected. Do you have any ideas about a better approach?

The solution here is basically:

Darken the shadow
Add some left/right margins to the webcontents so the shadow has somewhere to draw on the sides

fallaciousreasoning · 2024-10-01T01:54:43Z

browser/ui/views/frame/brave_contents_view_util.cc

-
+    .offset_y = 0,
+    .blur_radius = BraveContentsViewUtil::kMarginThickness,
+    .shadow_color = SkColorSetA(SK_ColorBLACK, 0.1 * 255)};


0.1 is actually what's in the Figma now, so this might have changed

fallaciousreasoning · 2024-10-01T01:55:29Z

browser/ui/views/frame/vertical_tab_strip_region_view.cc

    // View::ReorderChildView() didn't work for us. So remove child views and
    // add them again.
-    base::ranges::for_each(children(),
+    base::ranges::for_each(children_copy,


without this, I was encountering crashes - I've made a separate PR for this as it's not really related, and I don't know if this PR will land 😆

#25737

fallaciousreasoning · 2024-10-01T01:55:48Z

browser/ui/views/frame/vertical_tab_strip_region_view.cc

+      base::BindRepeating(&VerticalTabStripRegionView::OnBrowserPanelsMoved,
+                          base::Unretained(this)));
+
+  sidebar_side_.Init(


kinda sucks that vertical tabs needs to know about sidebar 😢

fallaciousreasoning · 2024-10-01T19:59:37Z

browser/ui/views/frame/brave_browser_view_layout.cc

  // Don't need contents container's left or right margin with vertical tab as
  // vertical tab itself has sufficient padding.
  if (tabs::utils::ShouldShowVerticalTabs(browser_view_->browser()) &&
      !IsFullscreenForBrowser()) {
    if (tabs::utils::IsVerticalTabOnRight(browser_view_->browser())) {
-      contents_margins.set_right(0);
+      contents_margins.set_right(contents_margin_for_rounded_corners);


This is where we remove the margin from the webcontents for vertical tabs. This fixes the issue, but it means we double pad @simonhong (the WebContents and the VerticalTabs sidebar)

fallaciousreasoning · 2024-10-01T20:00:05Z

browser/ui/views/frame/brave_browser_view_layout.cc

@@ -282,9 +291,9 @@ void BraveBrowserViewLayout::UpdateContentsContainerInsets(
  // If sidebar is shown in left-side, contents container doens't need its
  // left margin.
  if (sidebar_container_->sidebar_on_left()) {
-    contents_margins.set_left(0);
+    contents_margins.set_left(contents_margin_for_rounded_corners);


This is the same, but for the sidebar

fallaciousreasoning · 2024-10-01T20:00:45Z

browser/ui/views/frame/brave_contents_view_util.cc

-    .blur_radius = 4,
-    .shadow_color = SkColorSetA(SK_ColorBLACK, 0.07 * 255)};
-
+    .offset_y = 0,


With the offset_y set the shadow between the location bar and the web contents was hard to see, so I removed it

simonhong · 2024-10-02T02:31:49Z

After I cherry picked this PR's commits to latest master and enabled rounded corner feature, I got startup crash with this.
Curious this only happens to me.

[49481:259:1002/111318.455856:FATAL:vertical_tab_strip_region_view.cc(1105)] Check failed: width >= tabs::kVerticalTabMinWidth + tabs::kMarginForVerticalTabContainers * 2 (4 vs. 40)
0   libbase.dylib                       0x000000010f674e92 base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) + 18
1   libbase.dylib                       0x000000010f6558aa base::debug::StackTrace::StackTrace(unsigned long) + 106
2   libbase.dylib                       0x000000010f52e69e logging::LogMessage::Flush() + 190
3   libbase.dylib                       0x000000010f52e56d logging::LogMessage::~LogMessage() + 29
4   libbase.dylib                       0x000000010f5087d0 logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() + 112
5   libbase.dylib                       0x000000010f50882e logging::(anonymous namespace)::CheckLogMessage::~CheckLogMessage() + 14
6   libbase.dylib                       0x000000010f508463 logging::CheckError::~CheckError() + 35
7   libbase.dylib                       0x000000010f5084b9 logging::CheckError::~CheckError() + 9
8   libchrome_dll.dylib                 0x000000011d740721 VerticalTabStripRegionView::OnBoundsChanged(gfx::Rect const&) + 609
9   libui_views.dylib                   0x000000012c52c563 views::View::SetBoundsRect(gfx::Rect const&) + 1763
10  libui_views.dylib                   0x000000012c518529 views::LayoutManagerBase::ApplyLayout(views::ProposedLayout const&) + 425
11  libui_views.dylib                   0x000000012c518361 views::LayoutManagerBase::LayoutImpl() + 49
12  libui_views.dylib                   0x000000012c517b74 views::LayoutManagerBase::Layout(views::View*) + 132
13  libui_views.dylib                   0x000000012c52fb72 views::View::Layout(base::NonCopyablePassKey<views::View>) + 82
14  libui_views.dylib                   0x000000012c52ca95 views::View::LayoutImmediately() + 165
15  libui_views.dylib                   0x000000012c52c635 views::View::SetBoundsRect(gfx::Rect const&) + 1973
16  libui_views.dylib                   0x000000012c518529 views::LayoutManagerBase::ApplyLayout(views::ProposedLayout const&) + 425
17  libui_views.dylib                   0x000000012c518361 views::LayoutManagerBase::LayoutImpl() + 49
18  libui_views.dylib                   0x000000012c517b74 views::LayoutManagerBase::Layout(views::View*) + 132
19  libui_views.dylib                   0x000000012c52fb72 views::View::Layout(base::NonCopyablePassKey<views::View>) + 82
20  libui_views.dylib                   0x000000012c52ca95 views::View::LayoutImmediately() + 165
21  libui_views.dylib                   0x000000012c54f46b views::Widget::SetContentsView(views::View*) + 75
22  libui_views.dylib                   0x000000012c54caaa views::Widget::Init(views::Widget::InitParams) + 2090
23  libchrome_dll.dylib                 0x000000011d74604d VerticalTabStripWidgetDelegateView::Create(BrowserView*, views::View*) + 333
24  libchrome_dll.dylib                 0x000000011d6c8b36 BraveBrowserView::AddedToWidget() + 118
25  libui_views.dylib                   0x000000012c539fda views::View::PropagateAddNotifications(views::ViewHierarchyChangedDetails const&, bool) + 202
26  libui_views.dylib                   0x000000012c539136 views::View::AddChildViewAtImpl(views::View*, unsigned long) + 870
27  libui_views.dylib                   0x000000012c56f31b views::NonClientView::ViewHierarchyChanged(views::ViewHierarchyChangedDetails const&) + 75
28  libui_views.dylib                   0x000000012c539ca4 views::View::ViewHierarchyChangedImpl(views::ViewHierarchyChangedDetails const&) + 36
29  libui_views.dylib                   0x000000012c539fc4 views::View::PropagateAddNotifications(views::ViewHierarchyChangedDetails const&, bool) + 180
30  libui_views.dylib                   0x000000012c539136 views::View::AddChildViewAtImpl(views::View*, unsigned long) + 870
31  libui_views.dylib                   0x000000012c546851 views::internal::RootView::SetContentsView(views::View*) + 209
32  libui_views.dylib                   0x000000012c54cb65 views::Widget::Init(views::Widget::InitParams) + 2277
33  libchrome_dll.dylib                 0x000000012014c21b BrowserFrame::InitBrowserFrame() + 571
34  libchrome_dll.dylib                 0x000000012019578e BrowserWindow::CreateBrowserWindow(std::__Cr::unique_ptr<Browser, std::__Cr::default_delete<Browser>>, bool, bool) + 94
35  libchrome_dll.dylib                 0x000000011fcc5329 Browser::Browser(Browser::CreateParams const&) + 2169
36  libchrome_dll.dylib                 0x000000011d647722 BraveBrowser::BraveBrowser(Browser::CreateParams const&) + 18
37  libchrome_dll.dylib                 0x000000011fcc4a27 Browser::Create(Browser::CreateParams const&) + 55
38  libchrome_dll.dylib                 0x000000011e4fc333 SessionRestoreImpl::CreateRestoredBrowser(BrowserWindowInterface::Type, gfx::Rect, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool, ui::WindowShowState, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, std::__Cr::map<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, std::__Cr::less<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>, std::__Cr::allocator<std::__Cr::pair<std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>>>> const&, int) + 467
39  libchrome_dll.dylib                 0x000000011e4fb970 SessionRestoreImpl::ProcessSessionWindows(std::__Cr::vector<std::__Cr::unique_ptr<sessions::SessionWindow, std::__Cr::default_delete<sessions::SessionWindow>>, std::__Cr::allocator<std::__Cr::unique_ptr<sessions::SessionWindow, std::__Cr::default_delete<sessions::SessionWindow>>>>*, SessionID, std::__Cr::vector<SessionRestoreDelegate::RestoredTab, std::__Cr::allocator<SessionRestoreDelegate::RestoredTab>>&, int*, int*) + 528
40  libchrome_dll.dylib                 0x000000011e4f9e9e SessionRestoreImpl::ProcessSessionWindowsAndNotify(std::__Cr::vector<std::__Cr::unique_ptr<sessions::SessionWindow, std::__Cr::default_delete<sessions::SessionWindow>>, std::__Cr::allocator<std::__Cr::unique_ptr<sessions::SessionWindow, std::__Cr::default_delete<sessions::SessionWindow>>>>*, SessionID) + 62
41  libchrome_dll.dylib                 0x000000011e4f7544 SessionRestoreImpl::Restore() + 292

fallaciousreasoning · 2024-10-02T03:16:44Z

Huh, weird it doesn't work for you. I'll dig into it tomorrow. Out of interest, does it work if you disable the check?

simonhong · 2024-10-02T05:19:32Z

vertical_tab_strip_region_view.cc

It works w/o that check.
This doesn't happen with your branch. Latest master with your commit has this check failure.
Enabled vertical tab and restart. and seeing this failure.

browser/ui/brave_browser.cc

browser/ui/views/sidebar/sidebar_control_view.cc

fallaciousreasoning · 2024-10-03T02:40:19Z

@simonhong could you take another look?

simonhong · 2024-10-03T04:22:08Z

@fallaciousreasoning This PR really made browser window beautiful! 👍🏼

Sorry but I can see another startup crash after enabling vertical tab.

[15092:26488:1003/132004.072:FATAL:pref_member.h(119)] Check failed: !pref_name_.empty(). 
        base::debug::CollectStackTrace [0x00007FF8E65D8AB5+21] (C:\PRJ\brave-browser\src\base\debug\stack_trace_win.cc:332)
        base::debug::StackTrace::StackTrace [0x00007FF8E65B9434+100] (C:\PRJ\brave-browser\src\base\debug\stack_trace.cc:240)
        logging::LogMessage::Flush [0x00007FF8E6462264+244] (C:\PRJ\brave-browser\src\base\logging.cc:740)
        logging::LogMessage::~LogMessage [0x00007FF8E6462109+25] (C:\PRJ\brave-browser\src\base\logging.cc:728)
        logging::`anonymous namespace'::DCheckLogMessage::~DCheckLogMessage [0x00007FF8E6436A20+144] (C:\PRJ\brave-browser\src\base\check.cc:146)
        logging::CheckError::~CheckError [0x00007FF8E643632C+44] (C:\PRJ\brave-browser\src\base\check.cc:328)
        subtle::PrefMemberBase::VerifyPref [0x00007FF8E4E6F2B9+185] (C:\PRJ\brave-browser\src\components\prefs\pref_member.cc:83)
        PrefMember<bool>::GetValue [0x00007FF8C83116EF+31] (C:\PRJ\brave-browser\src\components\prefs\pref_member.h:241)
        VerticalTabStripRegionView::UpdateBorder [0x00007FF8CA7863A9+121] (C:\PRJ\brave-browser\src\brave\browser\ui\views\frame\vertical_tab_strip_region_view.cc:1230)
        VerticalTabStripRegionView::SetState [0x00007FF8CA785F0F+495] (C:\PRJ\brave-browser\src\brave\browser\ui\views\frame\vertical_tab_strip_region_view.cc:817)   
        VerticalTabStripRegionView::VerticalTabStripRegionView [0x00007FF8CA7849BD+4621] (C:\PRJ\brave-browser\src\brave\browser\ui\views\frame\vertical_tab_strip_region_view.cc:650)
        VerticalTabStripWidgetDelegateView::VerticalTabStripWidgetDelegateView [0x00007FF8CA78C791+289] (C:\PRJ\brave-browser\src\brave\browser\ui\views\frame\vertical_tab_strip_widget_delegate_view.cc:87)
        VerticalTabStripWidgetDelegateView::Create [0x00007FF8CA78C4A6+102] (C:\PRJ\brave-browser\src\brave\browser\ui\views\frame\vertical_tab_strip_widget_delegate_view.cc:52)
        BraveBrowserView::AddedToWidget [0x00007FF8CA70C609+137] (C:\PRJ\brave-browser\src\brave\browser\ui\views\frame\brave_browser_view.cc:888)
        views::View::PropagateAddNotifications [0x00007FF8E60F77B1+241] (C:\PRJ\brave-browser\src\ui\views\view.cc:3169)
        views::View::AddChildViewAtImpl [0x00007FF8E60F66DC+1164] (C:\PRJ\brave-browser\src\ui\views\view.cc:3042)
        views::NonClientView::ViewHierarchyChanged [0x00007FF8E6136F59+89] (C:\PRJ\brave-browser\src\ui\views\window\non_client_view.cc:329)
        views::View::ViewHierarchyChangedImpl [0x00007FF8E60F7403+67] (C:\PRJ\brave-browser\src\ui\views\view.cc:3189)
        views::View::PropagateAddNotifications [0x00007FF8E60F7796+214] (C:\PRJ\brave-browser\src\ui\views\view.cc:3167)
        views::View::AddChildViewAtImpl [0x00007FF8E60F66DC+1164] (C:\PRJ\brave-browser\src\ui\views\view.cc:3042)
        views::internal::RootView::SetContentsView [0x00007FF8E6107AF6+230] (C:\PRJ\brave-browser\src\ui\views\widget\root_view.cc:303)
        views::Widget::Init [0x00007FF8E610E925+2533] (C:\PRJ\brave-browser\src\ui\views\widget\widget.cc:507)
        BrowserFrame::InitBrowserFrame [0x00007FF8CC3E6750+656] (C:\PRJ\brave-browser\src\chrome\browser\ui\views\frame\browser_frame.cc:190)
        BrowserWindow::CreateBrowserWindow [0x00007FF8CD6A6933+163] (C:\PRJ\brave-browser\src\chrome\browser\ui\views\frame\browser_window_factory.cc:83)
        Browser::Browser [0x00007FF8CC5471B2+2322] (C:\PRJ\brave-browser\src\chrome\browser\ui\browser.cc:643)
        BraveBrowser::BraveBrowser [0x00007FF8CA677D5F+15] (C:\PRJ\brave-browser\src\brave\browser\ui\brave_browser.cc:60)
        Browser::Create [0x00007FF8CC546800+64] (C:\PRJ\brave-browser\src\chrome\browser\ui\browser.cc:532)

and I'm still seeing sidebar UI flickering when toggled. It would be great if we can avoid it!

fallaciousreasoning · 2024-10-04T00:31:53Z

Interestingly, I can reduce that error when I commit out the Init call on a PrefMember - I wonder it its because the pref isn't registered when I attempt to use it?

simonhong · 2024-10-04T01:02:30Z

Interestingly, I can reduce that error when I commit out the Init call on a PrefMember - I wonder it its because the pref isn't registered when I attempt to use it?

I'm not sure why but it seems empty during the startup?
How about handling empty condition sidebar_side_.GetPrefName().empty() and if it's empty, just use default(maybe right?) value. I think it would work?

fallaciousreasoning · 2024-10-04T01:04:39Z

I found it - it was because OnFloatingModePrefChanged was triggering a code path which used the variable! Think its ready for another look.

Thanks @simonhong for your help!

simonhong · 2024-10-04T03:09:43Z

Really nice! I think this is the last comment from me :) sorry for many complaints 🙏🏼
When vertical tab and sidebar has on the same side, there is a vertical line between them only on left side.
Curious what is our design? maybe both have same(have separator ot not on both).

simonhong

++ this touch is really nice 👍🏼

My last comment is optional as it's existing behavior. It's up to you!

fallaciousreasoning · 2024-10-04T03:13:33Z

Would it be okay if I fixed that as a follow up? This seems to be in latest Nightly already:

On Right:

On Left:

edit: too speedy!

fallaciousreasoning · 2024-10-07T01:02:02Z

@rebron do we want to uplift this to 1.71? I think we can leave it unless we're going to launch rounded corners, but might be worth having a look at the borders in 1.71 if not

brave-builds · 2024-10-07T12:04:58Z

Released in v1.72.66

rebron · 2024-10-07T13:12:57Z

@fallaciousreasoning We want to uplift this into 1.71.x. We still need to discuss if we'll do rounded corners at all for release.

kjozwiak · 2024-10-08T01:01:19Z

@fallaciousreasoning We want to uplift this into 1.71.x. We still need to discuss if we'll do rounded corners at all for release.

Closed #25856 (review) 👍

…)" This reverts commit 74b1dfa.

…) (#25880) Revert "[Rounded Corners]: Fix WebContents shadow in light mode (#25738)" This reverts commit 74b1dfa.

) (#25880) This reverts commit 6b7124e.

…h fixes (#25895) * Reapply "[Rounded Corners]: Fix WebContents shadow in light mode (#25738) (#25880) This reverts commit 6b7124e. * [Vertical Tabs]: Fix crash caused by uninitialized pref

fallaciousreasoning requested review from zenparsing and simonhong October 1, 2024 01:49

github-actions bot assigned fallaciousreasoning Oct 1, 2024

fallaciousreasoning commented Oct 1, 2024

View reviewed changes

fallaciousreasoning mentioned this pull request Oct 1, 2024

[Rounded Corners]: In rounded corners mode, there's no separation between the web_contents and the browser chrome brave/brave-browser#41313

Closed

fallaciousreasoning commented Oct 1, 2024

View reviewed changes

fallaciousreasoning force-pushed the webui-rounded-borders branch from 88db000 to 41da62f Compare October 2, 2024 03:16

simonhong reviewed Oct 2, 2024

View reviewed changes

browser/ui/brave_browser.cc Outdated Show resolved Hide resolved

browser/ui/views/sidebar/sidebar_control_view.cc Outdated Show resolved Hide resolved

browser/ui/views/sidebar/sidebar_control_view.cc Outdated Show resolved Hide resolved

fallaciousreasoning force-pushed the webui-rounded-borders branch from 41da62f to 8f92316 Compare October 3, 2024 02:04

fallaciousreasoning requested a review from a team as a code owner October 3, 2024 02:04

fallaciousreasoning force-pushed the webui-rounded-borders branch from 8f92316 to 003b481 Compare October 3, 2024 02:36

fallaciousreasoning requested a review from simonhong October 3, 2024 02:40

fallaciousreasoning requested a review from petemill October 3, 2024 02:40

github-actions bot added the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 4, 2024

fallaciousreasoning added 3 commits October 4, 2024 14:05

[Rounded Corners]: Fix shadows

89d754a

[Sidebar]: Fix margins

6c2a110

Refactoring to set the border on the panel instead

fb8b254

fallaciousreasoning added 6 commits October 4, 2024 14:05

Begin fixing panels

e52e86f

Add radius to all corners

87d5579

Cleanup for PR

6520b12

Fix DCHECK

57c1068

Fix flickering

f9a0f75

Fix PrefMember crash

651504a

fallaciousreasoning force-pushed the webui-rounded-borders branch from a52d4a9 to 651504a Compare October 4, 2024 01:05

github-actions bot removed the chromium-version-mismatch The Chromium version on the PR branch does not match the version on the target branch label Oct 4, 2024

simonhong approved these changes Oct 4, 2024

View reviewed changes

iefremov approved these changes Oct 4, 2024

View reviewed changes

fallaciousreasoning merged commit 74b1dfa into master Oct 7, 2024
17 checks passed

fallaciousreasoning deleted the webui-rounded-borders branch October 7, 2024 01:01

github-actions bot added this to the 1.72.x - Nightly milestone Oct 7, 2024

LaurenWags mentioned this pull request Oct 7, 2024

[Nala]: Remove Chromium color overrides brave/brave-browser#40689

Closed

brave-builds added a commit that referenced this pull request Oct 7, 2024

Uplift of #25738 (squashed) to beta

09f00b1

brave-builds mentioned this pull request Oct 7, 2024

[Rounded Corners]: Fix WebContents shadow in light mode (uplift to 1.71.x) #25856

Closed

7 tasks

iefremov added a commit that referenced this pull request Oct 8, 2024

Revert "[Rounded Corners]: Fix WebContents shadow in light mode (#25738…

18b55eb

…)" This reverts commit 74b1dfa.

kjozwiak pushed a commit that referenced this pull request Oct 8, 2024

Revert "[Rounded Corners]: Fix WebContents shadow in light mode (#25738…

6b7124e

…) (#25880) Revert "[Rounded Corners]: Fix WebContents shadow in light mode (#25738)" This reverts commit 74b1dfa.

fallaciousreasoning added a commit that referenced this pull request Oct 8, 2024

Reapply "[Rounded Corners]: Fix WebContents shadow in light mode (#25738

37c8589

) (#25880) This reverts commit 6b7124e.

This was referenced Oct 8, 2024

Reapply "[Rounded Corners]: Fix WebContents shadow in light mode" with fixes brave/brave-browser#41496

Closed

Reapply "[Rounded Corners]: Fix WebContents shadow in light mode" with fixes #25895

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Rounded Corners]: Fix WebContents shadow in light mode #25738

[Rounded Corners]: Fix WebContents shadow in light mode #25738

fallaciousreasoning commented Oct 1, 2024

fallaciousreasoning commented Oct 1, 2024 •

edited

Loading

fallaciousreasoning Oct 1, 2024

fallaciousreasoning Oct 1, 2024

fallaciousreasoning Oct 1, 2024

fallaciousreasoning Oct 1, 2024 •

edited

Loading

fallaciousreasoning Oct 1, 2024

fallaciousreasoning Oct 1, 2024

simonhong commented Oct 2, 2024

fallaciousreasoning commented Oct 2, 2024

simonhong commented Oct 2, 2024 •

edited

Loading

fallaciousreasoning commented Oct 3, 2024

simonhong commented Oct 3, 2024

fallaciousreasoning commented Oct 4, 2024

simonhong commented Oct 4, 2024 •

edited

Loading

fallaciousreasoning commented Oct 4, 2024 •

edited

Loading

simonhong commented Oct 4, 2024

simonhong left a comment

fallaciousreasoning commented Oct 4, 2024 •

edited

Loading

fallaciousreasoning commented Oct 7, 2024

brave-builds commented Oct 7, 2024

rebron commented Oct 7, 2024

kjozwiak commented Oct 8, 2024

[Rounded Corners]: Fix WebContents shadow in light mode #25738

[Rounded Corners]: Fix WebContents shadow in light mode #25738

Conversation

fallaciousreasoning commented Oct 1, 2024

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

fallaciousreasoning commented Oct 1, 2024 • edited Loading

fallaciousreasoning Oct 1, 2024

Choose a reason for hiding this comment

fallaciousreasoning Oct 1, 2024

Choose a reason for hiding this comment

fallaciousreasoning Oct 1, 2024

Choose a reason for hiding this comment

fallaciousreasoning Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

fallaciousreasoning Oct 1, 2024

Choose a reason for hiding this comment

fallaciousreasoning Oct 1, 2024

Choose a reason for hiding this comment

simonhong commented Oct 2, 2024

fallaciousreasoning commented Oct 2, 2024

simonhong commented Oct 2, 2024 • edited Loading

fallaciousreasoning commented Oct 3, 2024

simonhong commented Oct 3, 2024

fallaciousreasoning commented Oct 4, 2024

simonhong commented Oct 4, 2024 • edited Loading

fallaciousreasoning commented Oct 4, 2024 • edited Loading

simonhong commented Oct 4, 2024

simonhong left a comment

Choose a reason for hiding this comment

fallaciousreasoning commented Oct 4, 2024 • edited Loading

fallaciousreasoning commented Oct 7, 2024

brave-builds commented Oct 7, 2024

rebron commented Oct 7, 2024

kjozwiak commented Oct 8, 2024

fallaciousreasoning commented Oct 1, 2024 •

edited

Loading

fallaciousreasoning Oct 1, 2024 •

edited

Loading

simonhong commented Oct 2, 2024 •

edited

Loading

simonhong commented Oct 4, 2024 •

edited

Loading

fallaciousreasoning commented Oct 4, 2024 •

edited

Loading

fallaciousreasoning commented Oct 4, 2024 •

edited

Loading