Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sorry! Ads are not supported for this region" message will not be shown in some criteria #4187

Closed
GeetaSarvadnya opened this issue Apr 22, 2019 · 4 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 22, 2019

Description

"Sorry! Ads are not supported for this region" message will not be shown in some criteria

Steps to Reproduce

  1. Clean profile 0.63.46
  2. Set OS region to Ads not supported country ( e.g I have set it to India)
  3. Run ipleak.net to check IP ( my ip is set to India)
  4. Set OS locale to English(United States)
  5. Launch brave
  6. Enable Rewards

Actual result:

For India Region - Not getting "Sorry! Ads are not supported for this region" message

image

Expected result:

When IP address criteria itself fails, the message should be shown.

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa

@GeetaSarvadnya
Copy link
Author

@tmancey Even after page reload and browser restart "Sorry! Ads are not supported for this region" message" is not shown for Region India

@tmancey
Copy link
Contributor

tmancey commented Apr 25, 2019

Microsoft recommend using https://docs.microsoft.com/en-us/windows/desktop/intl/locale-sname to retrieve the locale. Microsoft must be using a multitude of settings to determine the locale, i.e. en_US which is out of control.

@tmancey
Copy link
Contributor

tmancey commented May 6, 2019

@GeetaSarvadnya @fmarier Can you please test latest nightly build as this was resolved in #4224

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 25, 2019

IP (India) + Locale (English (US)) - Ads will not be served as Region is set to ads not supported region and message "Sorry! Ads are not supported for this region" is NOT displayed which is as expected. Hence closing the issue.

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants