-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ads locale on Windows #4172
Comments
Verification passed on
|
@terry In one of the scenario even though Ads are disabled catalog is not empty is this expected? US IP Address(VPN)+Region(US)+Locale(English India)-Adds are disabled which is expected as one of the criteria fails (locale) but, the catalog is NOT empty is this expected? |
Region/locale are used currently to determine so this is correct based upon the code. Please check with Jimmy for confirmation too. Thanks |
@jsecretan Can you clarify the above query, please? |
Got reply for the above query which is as expected https://bravesoftware.slack.com/archives/C43LW5U2H/p1555933330241600?thread_ts=1555923498.238200&cid=C43LW5U2H |
Description
Ads locale returns incorrect region on Windows
Steps to Reproduce
Actual result:
Ads is not supported for US, UK, France, Germany and Canadian regions
Expected result:
Ads should be supported for US, UK, France, Germany and Canadian regions
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
0.65.70
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: