Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Tor integration compatible with NetworkService #4312

Closed
iefremov opened this issue May 6, 2019 · 5 comments · Fixed by brave/brave-core#2647
Closed

Make Tor integration compatible with NetworkService #4312

iefremov opened this issue May 6, 2019 · 5 comments · Fixed by brave/brave-core#2647

Comments

@iefremov
Copy link
Contributor

iefremov commented May 6, 2019

Test plan

See brave/brave-core#2647

Description

As part of migration we have to fix Tor - it doesn't work with enabled NetworkService. It seems that the reason is TorProfileServiceImpl::SetNewTorCircuitOnIOThread: URLRequestContext is not compatible with NetworkService.

@iefremov iefremov added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label May 6, 2019
@iefremov
Copy link
Contributor Author

iefremov commented May 6, 2019

@darkdh @riastradh-brave FYI

@iefremov
Copy link
Contributor Author

iefremov commented May 7, 2019

It is handy to use --enable-features=NetworkService to run Brave with NetworkService

@GeetaSarvadnya
Copy link

@darkdh When I launch brave using --enable-features=NetworkService flag. Open https://check.torproject.org/ in Tor windows doesn't connect to the tor network. But, as per the test plan brave/brave-core#2647, it should connect to tor network

image

@darkdh
Copy link
Member

darkdh commented Jul 18, 2019

@GeetaSarvadnya Did you launch it using fresh profile? There is another issue blocking this test case (#5007), so before #5007 is fixed, we have to launch without --enable-features=NetworkService switch and wait for tor executable to be downloaded and then relaunch with --enable-features=NetworkService and connect to tor network

@btlechowski
Copy link

btlechowski commented Jul 18, 2019

Verification passed on

Brave 0.67.111 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 7 Service Pack 1 (Build 7601.24494)

I was able to verify by using directions from brave/brave-core#2647 and #4312 (comment)
Steps used

  1. Clean install
  2. Run Brave
  3. Open Tor Window
  4. Wait till tor binaries are downloaded (Tor not working till browser restart if page is opened just after clean install #3512)
  5. Open https://check.torproject.org/ in Tor Window and make sure that Tor is working.
  6. Close Brave
  7. Run brave with --enable-features=NetworkService parameter
  8. Open Tor Window
  9. Open https://check.torproject.org/ in Tor Window and make sure that Tor is working.

Encountered #5007 and #3512

Verification passed on

Brave 0.67.111 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

Used above STR
Encountered #5007 and #3512

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.67.115 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants