Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split big bat_contribution file in ledger #4807

Closed
NejcZdovc opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2654
Closed

Split big bat_contribution file in ledger #4807

NejcZdovc opened this issue Jun 11, 2019 · 1 comment · Fixed by brave/brave-core#2654
Assignees
@NejcZdovc
Labels
dev-experience feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.68.x - Release

Comments

@NejcZdovc
Copy link
Contributor

Contribution file in native ledger is too big. We should split it into 4 pieces

  • contribution
  • phase_one
  • phase_two
  • unverified
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 11, 2019
@NejcZdovc NejcZdovc self-assigned this Jun 11, 2019
@NejcZdovc NejcZdovc mentioned this issue Jun 11, 2019
Merged
29 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jun 12, 2019
@NejcZdovc
Splits contribution file into multiple files
99ce304 
Resolves brave/brave-browser#4807
This was referenced Aug 2, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Aug 6, 2019 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Verification passed on

Brave 0.68.128 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-experience feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

Moves contribution into separate files brave/brave-core
4 participants
@NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya