Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine Trackers Blocked and Ads Blocked on NTP #5273

Closed
rebron opened this issue Jul 17, 2019 · 5 comments · Fixed by brave/brave-core#2950
Closed

combine Trackers Blocked and Ads Blocked on NTP #5273

rebron opened this issue Jul 17, 2019 · 5 comments · Fixed by brave/brave-core#2950
Assignees
Labels
design A design change, especially one which needs input from the design team feature/new-tab needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Jul 17, 2019

Description

On the new tab page, Trackers Blocked and Ads Blocked should be combined into a single count and labeled appropriately. For the backend, tracking-protection lib will move into the ad-block lib so good time to simplify and relabel this metric.

Current result:

Screen Shot 2019-07-17 at 11 44 07 AM

Expected result:

Single metric with label
[Count]
Ads & Trackers Blocked

@rebron
Copy link
Collaborator Author

rebron commented Jul 17, 2019

cc: @tomlowenthal for label text for this metric.

@rebron rebron added the design A design change, especially one which needs input from the design team label Jul 17, 2019
@cezaraugusto cezaraugusto self-assigned this Jul 17, 2019
@tildelowengrimm
Copy link
Contributor

I'd like to just collapse into "Trackers blocked".

@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Jul 17, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jul 18, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 19, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jul 23, 2019
@EyanGoldman
Copy link

Question that is probably unlikely, but what happens when you get to 1M + ads blocked, do the numbers dynamically shift to make space? Is there a risk of overlapping? This is especially relevant if we are merging ads and trackers as that number will grow much faster...

@cezaraugusto
Copy link
Contributor

@EyanGoldman yes, the stats row expands to fit larger numbers

@LaurenWags
Copy link
Member

LaurenWags commented Aug 5, 2019

Verified passed with

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X
  • Verified with clean profile:
    Screen Shot 2019-08-05 at 6 04 28 PM
  • Verified with upgraded profile. This is from 0.67.x:
    Screen Shot 2019-08-05 at 6 08 00 PM
    And after upgrading to 0.68.x the Ads/Trackers were combined as expected:
    Screen Shot 2019-08-05 at 6 08 59 PM

Verification passed on

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified with a clean profile

image

  • After upgrading to 0.68.x the Ads/Trackers were combined as expected

image

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Before upgrade
image
After Upgrade
image
Clean profile
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/new-tab needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants