-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave should not intercept non-navigation .torrent file requests #5361
Comments
WebTorrent users reporting the issue here: webtorrent/webtorrent#1649 |
If a web page embeds the WebTorrent client-side JS library and attempts to load a .torrent file using an XHR request or fetch, Brave will intercept the .torrent file load and replace it with the chrome-extension HTML, breaking the site. This is true not just for the WebTorrent JS library but for any request to fetch a .torrent file. Fixes: brave/brave-browser#5361 Fixes: brave/brave-browser#3164 Fixes: brave/brave-browser#1436
This also fixes this old issue: brave/browser-laptop#10672 |
@feross just a quick double check. When opening https://codepen.io/yciabaud/pen/XdOeWM while Is the above the expected behaviour? When you have WebTorrent either enabled or disabled, you'll get the above and Brave will start loading the |
@kjozwiak Yep, this is expected behavior. This is JavaScript code running on the website itself and has nothing to do with the built-in WebTorrent implementation in Brave. It's supposed to work in both cases -- when the WebTorrent extension is enabled or disabled. |
Verification PASSED on
Verification passed on
Verification passed on
|
Description
If a web page embeds the WebTorrent client-side JS library and attempts to load a
.torrent
file using an XHR request orfetch
, Brave will intercept the.torrent
file load and replace it with thechrome-extension
HTML, breaking the site. This is true not just for the WebTorrent JS library but for any request to fetch a.torrent
file.There's a CodePen that demonstrates this here: https://codepen.io/yciabaud/pen/XdOeWM
Steps to Reproduce
Actual result:
Expected result:
Brave should not intercept requests for
.torrent
files unless they are top-level navigation requests.Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: