Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start page is shown as new tab in shields #56

Closed
srirambv opened this issue Jan 16, 2018 · 4 comments
Closed

Start page is shown as new tab in shields #56

srirambv opened this issue Jan 16, 2018 · 4 comments

Comments

@srirambv
Copy link
Contributor

Clean install brave
Click continue on the start page which opens up Google.com
Click on shields, page title shows as newtab
image

@srirambv srirambv added the feature/shields The overall Shields feature in Brave. label Jan 16, 2018
@bbondy
Copy link
Member

bbondy commented Jan 20, 2018

@srirambv what's expected for this case?

@srirambv
Copy link
Contributor Author

srirambv commented Jan 23, 2018

@bbondy there are two things

  1. URL is missing which should be https://www.google.co.in/?gfe_rd=cr&dcr=0&ei=6bNmWsDtCNCBqAGGpKiACA (would change according to the region but should be the google home page)
  2. Since its the google homepage that is loaded, shields should show domain as google.com and not newtab

cezaraugusto pushed a commit that referenced this issue May 15, 2018
fix Linux build, GetDefaultUserDataDirectory issue, fix brave/brave#92
@bbondy bbondy added this to the Milestone 3: June-July milestone Jun 6, 2018
@srirambv
Copy link
Contributor Author

This looks fixed on c84b457. Not seeing the google launch page on start.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2018

Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants