Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards Panel cached information needs to expire/refresh #6059

Closed
masparrow opened this issue Sep 18, 2019 · 1 comment
Closed

Rewards Panel cached information needs to expire/refresh #6059

masparrow opened this issue Sep 18, 2019 · 1 comment
Labels
feature/rewards priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@masparrow
Copy link

masparrow commented Sep 18, 2019

Description

As noted in #5720 - if a user has previously attempted to contribute/contributed to a Vimeo publisher - they will have cached the site favicon, instead of the publishers portrait/favicon. This favicon is shown in several places.

We should expire the cache after 30 days generally so we can re-pull other site information as well. This will also fix some previous cases where some incorrect channel information was cached. For safety, we should expire the cache on the next upgrade as well.

Steps to Reproduce

See #5720 for the initial steps - and reproduce using a release build prior to the fix from brave/brave-core#3464
Using the build containing the fix from brave/brave-core#3464, revisit the same publisher and attempt to contribute.

Actual result:

The site favicon is shown.

Expected result:

The publisher portrait favicon should be shown.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

This issue will only be evident once brave/brave-core#3464 is released in a build.

Version/Channel Information:

This issue will only be evident once brave/brave-core#3464 is released in a build.

Other Additional Information:

Miscellaneous Information:

Should Vimeo ever change the portrait ID information we scrape, the issue reported in #5720 would reoccur, and any fix would result in the same 'stale cache' issue noted in this ticket.
As such, we need to ensure these favicons can be updated as and when future changes occur.

@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Sep 20, 2019
@jsecretan jsecretan changed the title Rewards Panel cached favicon needs to expire/refresh Rewards Panel cached information needs to expire/refresh Nov 4, 2019
@jsecretan jsecretan added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Nov 4, 2019
@NejcZdovc NejcZdovc added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 15, 2019
@Miyayes
Copy link
Collaborator

Miyayes commented Feb 9, 2022

Refiled here for freshness: #20980

@Miyayes Miyayes closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants