Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

favicon for verified vimeo publisher is incorrect #5720

Closed
LaurenWags opened this issue Aug 19, 2019 · 6 comments
Closed

favicon for verified vimeo publisher is incorrect #5720

LaurenWags opened this issue Aug 19, 2019 · 6 comments

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #4391

The favicon for a verified Vimeo publisher is incorrect in the panel, which means it is also incorrect in ac table and tips table.

Steps to Reproduce

  1. Navigate to a verified vimeo publisher.
  2. Open panel, view the favicon displayed in panel. Note, it does not match icon on verified publisher's page.
  3. View a video so that it gets added to your AC table.
  4. Tip the publisher.
  5. See same favicon on Tip and AC tables.

Note - if you repeat tests for unverified publisher, you correctly see generic vimeo favicon. This is expected.

Actual result:

Favicon for verified vimeo publisher does not match icon on their page.

Screen Shot 2019-08-19 at 10 39 19 AM

Screen Shot 2019-08-19 at 10 44 01 AM

Expected result:

Correct vimeo favicon on panel, ac, and tips tables.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.68.130 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X

Version/Channel Information:

  • Can you reproduce this issue with the current release? 0.67.x n/a, but 0.68.x (RC) yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? unsure, probably yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@LaurenWags
Copy link
Member Author

@LaurenWags
Copy link
Member Author

@NejcZdovc
Copy link
Contributor

+1 from #5752

@masparrow
Copy link

Nb. I have raised #6059 to describe the cached favicon change needed.

masparrow added a commit to brave/brave-core that referenced this issue Sep 19, 2019
masparrow added a commit to brave/brave-core that referenced this issue Sep 26, 2019
@emerick
Copy link
Contributor

emerick commented Nov 7, 2020

Fixed by brave/brave-core#6955

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 19, 2020

Verification passed on


Brave | 1.18.57 Chromium: 87.0.4280.66 (Official Build) beta (64-bit)
-- | --
Revision | fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS | Windows 10 OS Version 2004 (Build 19041.572)


Verified using

Brave | 1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | macOS Version 10.14.6 (Build 18G6042)

Reproduced issue as described. Comment added to #12781 (comment)


Verification passed on

Brave 1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (64-bit)
Revision 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS Ubuntu 18.04 LTS

Still reproducible #12781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment