Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tipping banner always shows a disabled vertical scrollbar #6222

Closed
btlechowski opened this issue Sep 30, 2019 · 2 comments · Fixed by brave/brave-core#4005
Closed

Tipping banner always shows a disabled vertical scrollbar #6222

btlechowski opened this issue Sep 30, 2019 · 2 comments · Fixed by brave/brave-core#4005

Comments

@btlechowski
Copy link

btlechowski commented Sep 30, 2019

Steps to Reproduce

  1. Enable rewards
  2. Go to a page (I used interia.pl)
  3. Tip the page

Actual result:

Tipping banner always shows a disabled vertical scrollbar
image

Expected result:

Vertical scrollbar is shown only when needed

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

cc @brave/legacy_qa @cg505 @NejcZdovc @ryanml

@btlechowski
Copy link
Author

Still reproducible

Brave 0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

image

cc @rebron

@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 14, 2019
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned ryanml Nov 18, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 18, 2019
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 18, 2019
@btlechowski
Copy link
Author

btlechowski commented Jan 4, 2020

Thanks for fixing. Looks good.

Verification passed on

Brave 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4005

image

image

Verified passed with

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Verified for a KYC'd publisher (one time and monthly tip banners):
Screen Shot 2020-01-07 at 12 52 05 PM
Screen Shot 2020-01-07 at 12 52 22 PM

Verified for a connected publisher, not KYC'd (one time and monthly tip banners):
Screen Shot 2020-01-07 at 12 52 48 PM
Screen Shot 2020-01-07 at 12 53 04 PM

Verified for an unverified publisher (one time and monthly tip banners):
Screen Shot 2020-01-07 at 12 53 27 PM
Screen Shot 2020-01-07 at 12 53 39 PM

Verification passed on

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified for a KYC'd publisher (one time and monthly tip banners):
image
image
Verified for a connected publisher (not KYC'd) (one time and monthly tip banners):
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants