Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple matched segments to trigger ads #6256

Closed
jsecretan opened this issue Oct 1, 2019 · 2 comments · Fixed by brave/brave-core#4073
Closed

Allow multiple matched segments to trigger ads #6256

jsecretan opened this issue Oct 1, 2019 · 2 comments · Fixed by brave/brave-core#4073
Assignees
@tmancey
Labels
enhancement feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.3.x - Release

Comments

@jsecretan
Copy link

Description

Currently, there are complaints from users about seeing ads repetitively. Some of this may be owing to the "winner-take-all" way that targeting functions. When a category is found to be the highest scoring during a particular ads session, it searches the catalog only for ads matching that category. It can therefore focus too narrowly on that dominant category, causing both too much repetition and limiting the breadth of ads the user can see.

We should therefore expand the breadth of targeting to include matching to the top 3 segments.
@jsecretan jsecretan added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. feature/ads labels Oct 1, 2019
@jsecretan jsecretan added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Nov 5, 2019
@jsecretan jsecretan assigned masparrow and tmancey and unassigned masparrow Nov 5, 2019
@tmancey tmancey mentioned this issue Nov 25, 2019
Merged
32 tasks
@tmancey
Copy link
Contributor

tmancey commented Nov 26, 2019

iOS failed, restarting iOS build

@tmancey tmancey added this to the 1.3.x - Nightly milestone Nov 27, 2019
@btlechowski
Copy link

btlechowski commented Jan 16, 2020 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Ubuntu 18.04 LTS

For the same ad

On 1.2.42 - only one segment is used:
image

On 1.3.92 - 3 segments are used

image

Also made sure that other segments are also used to show ads
image

Verified passed with

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified 3 segments

1 3 92 - 3 segments

Verification passed on

Brave 1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified multiple matched segments were shown when I tried to trigger an ad from Science catagory in a clean profile.
[9000:16112:0120/175054.961:INFO:ads_impl.cc(344)] Browser state changed to unidle
[9000:16112:0120/175054.975:INFO:ads_impl.cc(1041)] Serving ad from categories:
[9000:16112:0120/175054.975:INFO:ads_impl.cc(1043)]   business-business
[9000:16112:0120/175054.975:INFO:ads_impl.cc(1043)]   science-geology
[9000:16112:0120/175054.975:INFO:ads_impl.cc(1043)]   travel-adventure travel
[9000:16112:0120/175054.975:INFO:client.cc(574)] Successfully saved client state
[9000:16112:0120/175054.976:INFO:ads_impl.cc(1062)] No eligible ads found in categories:
[9000:16112:0120/175054.976:INFO:ads_impl.cc(1064)]   business-business
[9000:16112:0120/175054.976:INFO:ads_impl.cc(1064)]   science-geology
[9000:16112:0120/175054.976:INFO:ads_impl.cc(1064)]   travel-adventure travel
[9000:16112:0120/175054.976:INFO:ads_impl.cc(1093)] Serving ad from parent categories:
[9000:16112:0120/175054.976:INFO:ads_impl.cc(1095)]   business
[9000:16112:0120/175054.976:INFO:ads_impl.cc(1095)]   science
[9000:16112:0120/175054.976:INFO:ads_impl.cc(1095)]   travel
[9000:16112:0120/175054.978:INFO:ads_impl.cc(1057)] Found 20 eligible ads
[9000:16112:0120/175054.978:INFO:ads_impl.cc(1305)] Ad notification shown:
  id: 3030d60d-4e52-495f-b070-c557378db1cb
  campaign_id: fbcaa15b-fa96-43d4-a465-d1b78111d146
  advertiser: Us4Warriors
  category: science
  text: Helping Warriors Live Stronger Lives. Give Today
  url: https://www.us4warriors.org/crypto4warriors
  uuid: cc46d1be-a6db-4cbc-be84-a592cd4b01e4
[9000:16112:0120/175054.978:INFO:notifications.cc(262)] Saving notifications state
[16288:14048:0120/175054.979:INFO:confirmations_impl.cc(1038)] Confirm ad:
  id: 3030d60d-4e52-495f-b070-c557378db1cb
  creative_set_id: 29420f84-5e94-4295-b87f-77a11bdf5fbc
  advertiser: Us4Warriors
  category: science
  text: Helping Warriors Live Stronger Lives. Give Today
  url: https://www.us4warriors.org/crypto4warriors
  uuid: cc46d1be-a6db-4cbc-be84-a592cd4b01e4
  type: view
  • In 1.2.42 when I trigger an ad from business category ad triggers from businsess category and there are no multiple matching segments listed
[14460:3444:0120/175800.807:INFO:ads_impl.cc(343)] Browser state changed to unidle
[14460:3444:0120/175800.814:INFO:ads_impl.cc(974)] Serving ad for category: business-business
[14460:3444:0120/175800.815:INFO:client.cc(574)] Successfully saved client state
[14460:3444:0120/175800.815:INFO:client.cc(355)] Resetting seen Ads
[14460:3444:0120/175800.816:INFO:ads_impl.cc(1024)] No ads found in "business-business" category, trying again with "business" category
[14460:3444:0120/175800.820:INFO:client.cc(574)] Successfully saved client state
[14460:3444:0120/175800.820:INFO:ads_impl.cc(1055)] Found 10 eligible ads for "business" category
[14460:3444:0120/175800.821:INFO:ads_impl.cc(1226)] Notification shown:
  id: 35fe9250-af7d-41b8-811c-e66f97d0f21c
  campaign_id: 1cd20068-1ed5-4160-98b4-453d8071e516
  winnerOverTime: business-business
  advertiser: Portland State University
  category: business
  text: Online Business Blockchain Program. Learn more.
  url: https://www.pdx.edu/sba/business-blockchain-certificate-brave
  uuid: 31f9cdd7-547b-422f-b653-26de6e51da04
[14460:3444:0120/175800.823:INFO:notifications.cc(262)] Saving notifications state
[10528:15188:0120/175800.824:INFO:confirmations_impl.cc(1038)] Confirm ad:
  id: 35fe9250-af7d-41b8-811c-e66f97d0f21c
  creative_set_id: 9d7f064c-bf17-494b-842f-a42302e476fe
  advertiser: Portland State University
  category: business
  text: Online Business Blockchain Program. Learn more.
  url: https://www.pdx.edu/sba/business-blockchain-certificate-brave
  uuid: 31f9cdd7-547b-422f-b653-26de6e51da04
  type: view
  • Upgrade 1.2.42 profile to 1.3.94 and view an Ad and ensure multiple matching segments were shown
[6516:17356:0120/181052.878:INFO:ads_impl.cc(344)] Browser state changed to unidle
[6516:17356:0120/181052.893:INFO:ads_impl.cc(1041)] Serving ad from categories:
[6516:17356:0120/181052.893:INFO:ads_impl.cc(1043)]   science-geology
[6516:17356:0120/181052.893:INFO:ads_impl.cc(1043)]   education-education
[6516:17356:0120/181052.893:INFO:ads_impl.cc(1043)]   travel-adventure travel
[6516:17356:0120/181052.893:INFO:client.cc(574)] Successfully saved client state
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1062)] No eligible ads found in categories:
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1064)]   science-geology
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1064)]   education-education
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1064)]   travel-adventure travel
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1093)] Serving ad from parent categories:
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1095)]   science
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1095)]   education
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1095)]   travel
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[6516:17356:0120/181052.894:INFO:ads_impl.cc(1057)] Found 20 eligible ads
[6516:17356:0120/181052.895:INFO:ads_impl.cc(1305)] Ad notification shown:
  id: e8245c6c-f377-4f6b-afe4-2bc9ab4fa7f7
  campaign_id: fbcaa15b-fa96-43d4-a465-d1b78111d146
  advertiser: Us4Warriors
  category: education
  text: Veterans served for us all. Help us serve them. Donate today
  url: https://www.us4warriors.org/crypto4warriors
  uuid: 48835606-9c12-401c-9a4c-914441b6ace8
[6516:17356:0120/181052.895:INFO:notifications.cc(262)] Saving notifications state
[4236:15904:0120/181052.895:INFO:confirmations_impl.cc(1038)] Confirm ad:
  id: e8245c6c-f377-4f6b-afe4-2bc9ab4fa7f7
  creative_set_id: 29420f84-5e94-4295-b87f-77a11bdf5fbc
  advertiser: Us4Warriors
  category: education
  text: Veterans served for us all. Help us serve them. Donate today
  url: https://www.us4warriors.org/crypto4warriors
  uuid: 48835606-9c12-401c-9a4c-914441b6ace8
  type: view
[4236:15904:0120/181052.895:INFO:redeem_token.cc(57)

@LaurenWags LaurenWags mentioned this issue Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Allow multiple matched segments to trigger ads brave/brave-core
6 participants
@jsecretan @tmancey @masparrow @LaurenWags @btlechowski @GeetaSarvadnya