Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate matched segments when triggering ads #7118

Closed
tmancey opened this issue Nov 27, 2019 · 4 comments · Fixed by brave/brave-core#4084
Closed

Remove duplicate matched segments when triggering ads #7118

tmancey opened this issue Nov 27, 2019 · 4 comments · Fixed by brave/brave-core#4084
Assignees
@tmancey
Labels
bug feature/ads QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.3.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Nov 27, 2019 •
edited
Loading

Description

Remove duplicate matched segments when triggering ads

Steps to Reproduce

  1. Fresh install
  2. View an ad

Actual result:

Ads are matched with duplicate segments

Expected result:

Ads should not be matched with duplicate segments

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.3.5

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

See console log (no duplciate entries for categories should be shown):

[69251:775:1127/044306.324219:INFO:ads_impl.cc(344)] Browser state changed to unidle
[69251:775:1127/044306.338925:INFO:ads_impl.cc(1041)] Serving ad from categories:
[69251:775:1127/044306.360953:INFO:ads_impl.cc(1043)]   personal finance-personal finance
[69251:775:1127/044306.361200:INFO:ads_impl.cc(1043)]   personal finance-banking
[69251:775:1127/044306.361354:INFO:ads_impl.cc(1043)]   personal finance-credit & debt & loans
[69251:775:1127/044306.362310:INFO:client.cc(574)] Successfully saved client state
[69251:775:1127/044306.363383:INFO:ads_impl.cc(1062)] No eligible ads found in categories:
[69251:775:1127/044306.363621:INFO:ads_impl.cc(1064)]   personal finance-personal finance
[69251:775:1127/044306.363770:INFO:ads_impl.cc(1064)]   personal finance-banking
[69251:775:1127/044306.363909:INFO:ads_impl.cc(1064)]   personal finance-credit & debt & loans
[69251:775:1127/044306.364065:INFO:ads_impl.cc(1093)] Serving ad from parent categories:
[69251:775:1127/044306.364206:INFO:ads_impl.cc(1095)]   personal finance
[69251:775:1127/044306.367238:INFO:ads_impl.cc(1057)] Found 24 eligible ads
[69251:775:1127/044306.367892:INFO:ads_impl.cc(1305)] Ad notification shown:
 id: d917ee81-c48b-47f3-b579-248c4a2952fa
 campaign_id: dbd742cc-7bcf-47c8-aeed-5a8be10c7261
 advertiser: Coinvest Vault
 category: personal finance
 text: Secure millions in digital assets for only $249. Pre-order now.
 url: https://vault.coinve.st/
 uuid: 7d04db29-b02c-4126-ba8e-65ac4fe61243```
@tmancey tmancey added this to the 1.3.x - Nightly milestone Nov 27, 2019
@tmancey tmancey self-assigned this Nov 27, 2019
@tmancey tmancey mentioned this issue Nov 27, 2019
Merged
32 tasks
@btlechowski
Copy link

@tmancey Is the console log from Miscellaneous Information expected behavior?

@tmancey
Copy link
Contributor Author

tmancey commented Dec 19, 2019

@btlechowski You should not see any taxonomy duplicates, i.e. see below there are no dups:

[69251:775:1127/044306.360953:INFO:ads_impl.cc(1043)] personal finance-personal finance
[69251:775:1127/044306.361200:INFO:ads_impl.cc(1043)] personal finance-banking
[69251:775:1127/044306.361354:INFO:ads_impl.cc(1043)] personal finance-credit & debt & loans

If you see:

[69251:775:1127/044306.361200:INFO:ads_impl.cc(1043)] personal finance-banking
[69251:775:1127/044306.361200:INFO:ads_impl.cc(1043)] personal finance-banking
[69251:775:1127/044306.361354:INFO:ads_impl.cc(1043)] personal finance-credit & debt & loans

or

[69251:775:1127/044306.361200:INFO:ads_impl.cc(1043)] personal finance
[69251:775:1127/044306.361200:INFO:ads_impl.cc(1043)] personal finance
[69251:775:1127/044306.361354:INFO:ads_impl.cc(1043)] home

*taxonomies will not match as depends on your browsing

@LaurenWags
Copy link
Member

LaurenWags commented Jan 16, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified multiple segments

1 3 92 - 3 segments

  • After receiving ad above, I visited only sites with parent classification as personal finance, confirmed that when it was time for another ad, there were no duplicate segments listed:

Screen Shot 2020-01-16 at 6 01 13 PM

  • On a fresh profile I only visited one site, with parent classification as technology and computing. When it was time for an ad, confirmed there were no duplicate segments listed:

Screen Shot 2020-01-16 at 6 05 23 PM

Verification passed on

Brave 1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • On a clean profile- visited one site from technology and computing category, verified multiple segments were shown and ads triggered from business category (chiled category) and verified there are no duplicate segments listed
[12276:13948:0120/170439.057:INFO:ads_impl.cc(344)] Browser state changed to unidle
[12276:13948:0120/170439.072:INFO:ads_impl.cc(1041)] Serving ad from categories:
[12276:13948:0120/170439.072:INFO:ads_impl.cc(1043)]   technology & computing-unix
[12276:13948:0120/170439.072:INFO:ads_impl.cc(1043)]   business-business
[12276:13948:0120/170439.072:INFO:ads_impl.cc(1043)]   technology & computing-gaming
[12276:13948:0120/170439.072:INFO:client.cc(574)] Successfully saved client state
[12276:13948:0120/170439.073:INFO:ads_impl.cc(1062)] No eligible ads found in categories:
[12276:13948:0120/170439.073:INFO:ads_impl.cc(1064)]   technology & computing-unix
[12276:13948:0120/170439.073:INFO:ads_impl.cc(1064)]   business-business
[12276:13948:0120/170439.073:INFO:ads_impl.cc(1064)]   technology & computing-gaming
[12276:13948:0120/170439.073:INFO:ads_impl.cc(1093)] Serving ad from parent categories:
[12276:13948:0120/170439.073:INFO:ads_impl.cc(1095)]   technology & computing
[12276:13948:0120/170439.073:INFO:ads_impl.cc(1095)]   business
[12276:13948:0120/170439.074:INFO:ads_impl.cc(1057)] Found 13 eligible ads
[12276:13948:0120/170439.075:INFO:ads_impl.cc(1305)] Ad notification shown:
  id: 7f0a1033-f571-4fd4-b7ec-41fb72378f4c
  campaign_id: 1cd20068-1ed5-4160-98b4-453d8071e516
  advertiser: Portland State University
  category: business
  text: Industry-driven online Business Blockchain Program.
  url: https://www.pdx.edu/sba/business-blockchain-certificate-brave
  uuid: d6084117-8a68-4861-a595-0b0c82d9bb4a
[12276:13948:0120/170439.075:INFO:notifications.cc(262)] Saving notifications state
[1056:12760:0120/170439.075:INFO:confirmations_impl.cc(1038)] Confirm ad:
  id: 7f0a1033-f571-4fd4-b7ec-41fb72378f4c
  creative_set_id: 9d7f064c-bf17-494b-842f-a42302e476fe
  advertiser: Portland State University
  category: business
  text: Industry-driven online Business Blockchain Program.
  url: https://www.pdx.edu/sba/business-blockchain-certificate-brave
  uuid: d6084117-8a68-4861-a595-0b0c82d9bb4a
  type: view
[1056:12760:0120/170439.075:INFO:redeem_token.cc(57)] Redeem
  • Verified multiple segments were listed when I tried to trigger an ad from education segment after viewing ads from business segment, confirmed there are no duplicate entries of segments
[13544:15108:0120/172343.671:INFO:ads_impl.cc(344)] Browser state changed to unidle
[13544:15108:0120/172343.686:INFO:ads_impl.cc(1041)] Serving ad from categories:
[13544:15108:0120/172343.686:INFO:ads_impl.cc(1043)]   technology & computing-unix
[13544:15108:0120/172343.686:INFO:ads_impl.cc(1043)]   education-education
[13544:15108:0120/172343.686:INFO:ads_impl.cc(1043)]   business-business
[13544:15108:0120/172343.686:INFO:client.cc(574)] Successfully saved client state
[13544:15108:0120/172343.687:INFO:ads_impl.cc(1062)] No eligible ads found in categories:
[13544:15108:0120/172343.687:INFO:ads_impl.cc(1064)]   technology & computing-unix
[13544:15108:0120/172343.687:INFO:ads_impl.cc(1064)]   education-education
[13544:15108:0120/172343.687:INFO:ads_impl.cc(1064)]   business-business
[13544:15108:0120/172343.687:INFO:ads_impl.cc(1093)] Serving ad from parent categories:
[13544:15108:0120/172343.687:INFO:ads_impl.cc(1095)]   technology & computing
[13544:15108:0120/172343.687:INFO:ads_impl.cc(1095)]   education
[13544:15108:0120/172343.687:INFO:ads_impl.cc(1095)]   business
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1192)] creativeSetId 9d7f064c-bf17-494b-842f-a42302e476fe has exceeded the frequency capping for perDay
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1192)] campaignId 1cd20068-1ed5-4160-98b4-453d8071e516 has exceeded the frequency capping for dailyCap
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1192)] creativeSetId 9d7f064c-bf17-494b-842f-a42302e476fe has exceeded the frequency capping for perDay
[13544:15108:0120/172343.689:INFO:ads_impl.cc(1057)] Found 18 eligible ads
[13544:15108:0120/172343.690:INFO:ads_impl.cc(1305)] Ad notification shown:
  id: d9dd58ed-a605-441d-8b3d-61141192501a
  campaign_id: 8794493c-a5e6-418e-9a59-a8937e993544
  advertiser: BlockFi
  category: business
  text: Earn up to 8.6% APY on your crypto - Get started
  url: https://try.blockfi.com/earn-crypto-bq1/?ref=braveq12020&utm_source=Brave&utm_medium=paid&utm_campaign=Brave-Jan2020&utm_content=Earn_CR_Jan20-2_1
  uuid: b21b7438-5724-487d-88ce-50f76f612934
[13544:15108:0120/172343.690:INFO:notifications.cc(262)] Saving notifications state
[1580:532:0120/172343.690:INFO:confirmations_impl.cc(1038)] Confirm ad:
  id: d9dd58ed-a605-441d-8b3d-61141192501a
  creative_set_id: c7f48c91-6d3c-48f0-b0dd-c1108f968f17
  advertiser: BlockFi
  category: business
  text: Earn up to 8.6% APY on your crypto - Get started
  url: https://try.blockfi.com/earn-crypto-bq1/?ref=braveq12020&utm_source=Brave&utm_medium=paid&utm_campaign=Brave-Jan2020&utm_content=Earn_CR_Jan20-2_1
  uuid: b21b7438-5724-487d-88ce-50f76f612934
  type: view

On a clean profile when i tried to trigger an ad from Fashion category ad triggered from fashion-beauty category and observed multiple categories listed and there are no duplicate segments listed.

[15208:15260:0120/173537.175:INFO:ads_impl.cc(1041)] Serving ad from categories:
[15208:15260:0120/173537.175:INFO:ads_impl.cc(1043)]   fashion-fashion
[15208:15260:0120/173537.175:INFO:ads_impl.cc(1043)]   fashion-clothing
[15208:15260:0120/173537.175:INFO:ads_impl.cc(1043)]   fashion-beauty
[15208:15260:0120/173537.177:INFO:client.cc(574)] Successfully saved client state
[15208:15260:0120/173537.178:INFO:ads_impl.cc(1057)] Found 2 eligible ads
[15208:15260:0120/173537.178:INFO:ads_impl.cc(1305)] Ad notification shown:
  id: 80eef273-2611-4e40-9759-d9862ebfaaef
  campaign_id: 931a4278-d194-4801-87db-885350da0bc2
  advertiser: Indochino
  category: fashion-beauty
  text: Use code BRAVE for special Indochino offer
  url: https://www.indochino.com/collection/premium-suits?utm_source=brave&utm_medium=display&utm_campaign=2019
  uuid: d09da8e4-dcac-4bf5-b14d-d07ec90b63da
[15208:15260:0120/173537.178:INFO:notifications.cc(262)] Saving notifications state
[10172:3328:0120/173537.179:INFO:confirmations_impl.cc(1038)] Confirm ad:
  id: 80eef273-2611-4e40-9759-d9862ebfaaef
  creative_set_id: 147a9a34-daba-45eb-a129-30e0de93d4e5
  advertiser: Indochino
  category: fashion-beauty
  text: Use code BRAVE for special Indochino offer
  url: https://www.indochino.com/collection/premium-suits?utm_source=brave&utm_medium=display&utm_campaign=2019
  uuid: d09da8e4-dcac-4bf5-b14d-d07ec90b63da
  type: view
[10172:3328:0120/173537.179:INFO:redeem_token.cc(57)] Redeem

@btlechowski
Copy link

Verification passed on

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Ubuntu 18.04 LTS
Verified for few pages that there is no duplicate segments per #7118 (comment)

Page: https://www.fashionnova.com/
image

Page: https://www.investopedia.com/articles/personal-finance/100516/setting-financial-goals/
image

Page: https://www.imdb.com/
image

Page: https://www.khanacademy.org/
image

Page: https://hobbyhelp.com/inspiration/list-of-hobbies/
image

@btlechowski btlechowski mentioned this issue Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes remove duplicate matched segments when triggering ads brave/brave-core
4 participants
@tmancey @LaurenWags @btlechowski @GeetaSarvadnya