Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://wallet should always open in normal window #6637

Closed
btlechowski opened this issue Oct 28, 2019 · 1 comment · Fixed by brave/brave-core#4032
Closed

brave://wallet should always open in normal window #6637

btlechowski opened this issue Oct 28, 2019 · 1 comment · Fixed by brave/brave-core#4032

Comments

@btlechowski
Copy link

brave://sync, brave://rewards, brave://history, brave://settings are always opened in normal window, even when opened from private window or private window with Tor.
brave://wallet should match this behavior.

Steps to Reproduce

  1. Open New private window / New private window with Tor
  2. Open brave://wallet

Note: brave://wallet is available from Hamburger menu in private window / private window with Tor
image

Actual result:

brave://wallet is opened in private window / private window with Tor
image
image

Expected result:

brave://wallet is opened in normal window

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron

@btlechowski
Copy link
Author

btlechowski commented Dec 18, 2019

Verification passed on

Brave 1.3.68 Chromium: 79.0.3945.79 (Official Build) dev (64-bit)
Revision 29f75ce3f42b007bd80361b0dfcfee3a13ff90b8-refs/branch-heads/3945@{#916}
OS Ubuntu 18.04 LTS

Verified test plan from the description.
Verified that brave://wallet is opened in normal window when opened from Private Window
Verified that brave://wallet is opened in normal window when opened from Private Window with Tor

Verified that Brave Wallet is opened in normal window when opened from Hamburger Menu from Private Window
Verified that Brave Wallet is opened in normal window when opened from Hamburger Menu from Private Window with Tor

Opening brave://wallet from Guest Window is blocked in the Guest Window. This is expected as other links like brave://sync are handled the same.

Verification passed on

Brave 1.3.75 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from the description.
  • Verified that Brave wallet is opened in Normal window when Crypto wallet is opened from Private window and Tor windows
  • Verified that the brave://wallet is in disabled and Crypto wallet option is removed from the Hamburger menu in Normal, Private and Tor windows when Crypto Wallet switch is disabled in settings.

Verified passed with

Brave 1.3.87 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified STR from description
  • Verified opening Crypto Wallets from hamburger menu on Private Window or Private Window with Tor opens brave://wallet in normal tab
  • Verified opening brave://wallet from URL bar on Private Window or Private Window with Tor opens brave://wallet in normal tab
  • Verified that the brave://wallet is in disabled and Crypto wallet option is removed from the Hamburger menu in Normal, Private and Tor windows when Crypto Wallet switch is disabled in settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment