Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting to use Crypto Wallets over MetaMask (MM) should disable MM #6687

Closed
bbondy opened this issue Oct 31, 2019 · 3 comments
Closed

Selecting to use Crypto Wallets over MetaMask (MM) should disable MM #6687

bbondy opened this issue Oct 31, 2019 · 3 comments
Assignees
@bbondy
Labels
feature/ethereum-remote-client priority/P2 A bad problem. We might uplift this to the next planned release.
Milestone
Closed / Dupe / I...

Comments

@bbondy
Copy link
Member

bbondy commented Oct 31, 2019

Screen Shot 2019-10-24 at 2 58 54 PM

Currently if the user selects to use Crypto Wallets we disable Crypto Wallets, but we don't actively disable MM the other way around. We should make this symmetric and disable it if the user selects that way.
@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 31, 2019
@bbondy bbondy mentioned this issue Oct 31, 2019
Closed
@srirambv
Copy link
Contributor

@bbondy Instead of completely disabling MM we should prompt the user to import from MM. Clicking Use Crypto Wallets should automatically trigger the restore wallet button to allow the user to enter the 12 code words to import wallet

@ryanml ryanml self-assigned this Dec 11, 2019
@bbondy
Copy link
Member Author

bbondy commented Dec 12, 2019

@srirambv pls post the suggestion as a separate issue. I think unbreaking for now is more important for the short term and we'd be able to get this done vs what you are suggesting faster.

@ryanml ryanml assigned bbondy and unassigned ryanml Dec 13, 2019
@bbondy
Copy link
Member Author

bbondy commented Dec 20, 2019

This will be deprecated with this work, so I'm closing this issue:
#7503

@bbondy bbondy closed this as completed Dec 20, 2019
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/ethereum-remote-client priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
None yet
Milestone
Closed / Dupe / Invalid
Development

No branches or pull requests
3 participants
@bbondy @ryanml @srirambv