Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use infobars for Dapp detection and warn for MetaMask #6600

Closed
bbondy opened this issue Oct 24, 2019 · 1 comment · Fixed by brave/brave-core#3791
Closed

Use infobars for Dapp detection and warn for MetaMask #6600

bbondy opened this issue Oct 24, 2019 · 1 comment · Fixed by brave/brave-core#3791

Comments

@bbondy
Copy link
Member

bbondy commented Oct 24, 2019

Feature change description

We used to show a popup about Dapp detection with little info.
The new UI is to show an info-bar.

MetaMask installed

Screen Shot 2019-10-24 at 2 58 54 PM

If MetaMask is installed, it will give 2 options and a dismiss option.

  • Selecting use Crypto Wallets will make the extension install
  • Selecting use MetaMask will make it set the preference for the Crypto Wallets to off in settings.
  • Dismissing just gets rid of it but does nothing else.

MetaMask not installed

Screen Shot 2019-10-24 at 2 10 00 PM

If MetaMask is not installed, it will just give a setup and dismiss option.

  • Clicking SETUP uses Crypto Wallets will make the extension install
  • Dismissing just gets rid of it but does nothing else.

Extra info for QA

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 2, 2020

Verification passed on

Brave 1.2.39 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the description and extra QA info mentioned in the issue

When MM isn't installed:

  • Verified the info-bar displayed with SETUP and dismiss options when MM is not installed
    image

  • Verified that click on SETUP opens up brave://wallet page and makes extension installed

  • Verified clicking on dismiss (x) just dismiss the info-bar

When MM is installed:

  • Verified that info-bar is displayed with Use Crypto Wallets, Use MetaMask and dismiss options when MM is installed
    image

  • Verified that click on Use MetaMask will set Crypto Wallet settings to OFF state in chrome://settings/extensions

  • Verified that click on Use Crypto Wallet opens up brave://wallet page and makes extension installed

  • Verified clicking on dismiss (x) just dismiss the info-bar


Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.2.40 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.15.2 (Build 19C57)

When MM is installed:

Screen Shot 2020-01-03 at 12 01 44 AM

  • Verified that the notification is being displayed when visiting https://www.cryptokitties.co/ and https://memefactory.io/
  • Verified that the notification is still displayed when it's dismissed via the X when visiting DApps
  • Verified that the notification can be displayed on multiple tabs without any issues
  • Verified that dismissing the notification via the X only dismisses the notification for that particular tab
  • Verified that selecting Use MetaMask disabled the Crypto Wallet settings under brave://settings/extensions
  • Verified that re-enabling Crypto Walletunderbrave://settings/extensionswill redisplay the notification ifCrypto Walletswasn't enabled by visitingbrave://wallet`
  • Verified that selecting Use Crypto Wallets brave://wallet and loads the extension

When MM isn't installed:

Screen Shot 2020-01-02 at 11 14 09 PM

  • Verified that the notification is being displayed when visiting https://www.cryptokitties.co/ and https://memefactory.io/
  • Verified that the notification is still displayed when it's dismissed via the X when visiting DApps
  • Verified that clicking on SETUP correctly opens brave://wallet and loads the extension
  • Verified that the notification can be displayed on multiple tabs without any issues
  • Verified that dismissing the notification via the X only dismisses the notification for that particular tab
  • Verified that the notification isn't displayed when brave://wallet was enabled/loaded

Verification passed on

  • When MM is not installed

    • Verified visiting a Dapp shows the below setup notification bar
      image
    • Verified dismissing the notification doesn't download the component
    • Verified clicking the Setup button loads brave://wallet in a new tab and downloads the component
    • Verified the notification doesn't show when Crypto Wallet extension is disabled (with or without lazy load)
    • Verified notification is shown on multiple tabs where Dapps are detected
    • Verified closing the notification via X and reloading the page shows the setup notification again
  • When MM is installed

    • Verified visiting a Dapp shows the below setup notification bar when CW isn't setup
      image
    • Verified notification can be closed via X and neither MM or CW is setup
    • Verified closing notification via X and reloading the Dapp page shows the notification again
    • Verified notification doesn't show up when either CW/MM is selected
    • Verified notification is shown on multiple tabs where Dapp is detected
    • Verified selecting CW doesn't change anything with MM
    • Verified selecting MM disables CW in settings
    • Verified re-enabling CW in settings shows the notification again when a Dapp is detected
    • Verified selecting CW opens brave://wallet in a new tab and downloads the component

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment