Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove macOS changes for "Fix user earns while native Windows and macOS notifications are suppressed" #6818

Closed
tmancey opened this issue Nov 7, 2019 · 2 comments · Fixed by brave/brave-core#3907
Closed

Remove macOS changes for "Fix user earns while native Windows and macOS notifications are suppressed" #6818

tmancey opened this issue Nov 7, 2019 · 2 comments · Fixed by brave/brave-core#3907
Assignees
@tmancey
Labels
feature/ads feature/rewards OS/macOS QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.3.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Nov 7, 2019 •
edited
Loading

Remove macOS changes for "Fix user earns while native Windows and macOS notifications are suppressed" as until we transition from NSUserNotificationCenter to UNUserNotificationCenter notifications will not appear. I will comment out the code ready for re-implementation at a later date once we are using UNUserNotificationCenter
@tmancey tmancey added this to the 0.74.x - Nightly milestone Nov 7, 2019
@tmancey tmancey self-assigned this Nov 7, 2019
@tmancey tmancey mentioned this issue Nov 7, 2019
Merged
32 tasks
@tmancey tmancey changed the title Revert macOS changes for "Fix user earns while native Windows and macOS notifications are suppressed" Remove macOS changes for "Fix user earns while native Windows and macOS notifications are suppressed" Nov 7, 2019
@tmancey tmancey added the QA/Yes label Nov 7, 2019
tmancey added a commit to brave/brave-core that referenced this issue Nov 7, 2019
@tmancey
Remove macOS changes for "Fix user earns while native Windows and mac…
a44238b 
…OS notifications are suppressed"

Fixes brave/brave-browser#6818
@tmancey tmancey removed this from the 0.74.x - Nightly milestone Nov 7, 2019
@tmancey tmancey added this to the 0.74.x - Nightly milestone Nov 7, 2019
@btlechowski
Copy link

Based on the test plan from brave/brave-core#3907, this issue is macOS only. Added proper flags.

@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)

Going to label this as QA Pass-macOS as ad notifications were checked via #6786 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads feature/rewards OS/macOS QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
4 participants
@tmancey @kjozwiak @LaurenWags @btlechowski