Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional phase of Brave Ads regions #6825

Closed
jsecretan opened this issue Nov 7, 2019 · 2 comments · Fixed by brave/brave-core#3983
Closed

Additional phase of Brave Ads regions #6825

jsecretan opened this issue Nov 7, 2019 · 2 comments · Fixed by brave/brave-core#3983

Comments

@jsecretan
Copy link

jsecretan commented Nov 7, 2019

Description

We want to bring on some additional regions into Brave Ads including:
Arab Emirates, Albania, Azerbaijan, Bangladesh, Belgium, Bulgaria, China, Czech Republic, Algeria, Egypt, Spain, Finland, Greece, Hong Kong, Croatia, Hungary, Indonesia, Iraq, Cambodia, Lithuania, Morocco, Malaysia, Nigeria, Norway, Pakistan, Portugal, Romania, Serbia, Russia, Saudi Arabia, Slovenia, Slovakia, Thailand, Turkey, Taiwan, Ukraine, Vietnam

@LaurenWags
Copy link
Member

QA/Blocked until #7741 is resolved

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 4, 2020

Verification passed on

Brave 1.3.109 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Clean profile 1.3.x

  • Verified ads for countries Belgium, Bulgaria, Finland, Greece, and Norway in a clean profile
    • ensured enable Rewards enables Ads as expected
    • ensured Ads notifications are shown as expected
    • ensured Ads notifications received, Estimated pending rewards and history stats are updated as expected
    • ensured unblinded tokens were refilled logs are shown
    • ensured View, Click, landed, and dismiss event types are recorded in logs
    • ensured that, once ads were viewed Ad notification shown messages were shown in logs
    • ensured that, when Ads are disabled Ads shown messages were not shown in logs
    • ensured when Ads are re-enabled Ads messages were shown in logs
    • ensured token redemption is successful (using Ephoch converter)

Upgraded profile 1.3.x

  • Upgraded profile from 1.2.43 to 1.3.x and verified ads for countries Belgium, Bulgaria, Finland, Greece, and Norway in a clean profile
    • ensured Sorry! ads not yet available message is shown in Ads panel in 1.2.x
    • ensured BAT logo notification is show and Ads are in disable state in 1.3.x
    • ensured click on Turn on Ads in enable ads notification doesn't make Ads switch ON
    • ensured Ads switch is disabled by default and it can be enabled
    • ensured Ads were shown in upgraded profile 1.3.x

Upgraded profile 1.3.x

  • Installed 1.2.43 disable Rewards and upgrade to 1.3.x
    • ensured Rewards switch is still OFF after upgrade
    • ensured Rewards/Ads can be enabled
    • ensured Ads were viewed
Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Версия 10.14.6 (Выпуск 18G103)
  • Executed the following 3 test cases for Russia, Spain, Belgium - all 3 cases passed for all 3 countries PASSED
  1. Install 1.2.43 --> keep Rewards off. Upgrade to 1.3.x.

    • Confirmed Rewards still off
    • Confirmed when enabling Rewards Ads are enabled by default
  2. Install 1.2.43 --> enable Rewards. Confirm Sorry message on Ads panel. Upgrade to 1.3.x.

    • Confirm BAT logo notifying user that Ads are available in their region
    • Confirm Ads not enabled by default
    • Confirm able to turn Ads on and receive an Ad notification
  3. Install 1.3.x. Enable Rewards.

    • Confirm Ads enabled by default
    • Confirm able to receive an Ad notification
    • Confirmed Ads panel info is updated as expected
    • Confirmed NTP widget is updated as expected

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Ubuntu 18.04 LTS
  • Verified the following 3 test cases for Bulgaria, Portugal, Lithuania, Ukraine
  1. Install 1.2.43 --> keep Rewards off. Upgrade to 1.3.x.

    • Confirmed Rewards still off
    • Confirmed when enabling Rewards Ads are enabled by default
  2. Install 1.2.43 --> enable Rewards. Confirm Sorry message on Ads panel. Upgrade to 1.3.x.

    • Confirm BAT logo notifying user that Ads are available in their region
    • Confirm Ads not enabled by default
    • Confirm able to turn Ads on and receive an Ad notification

Example Bulgaria:
image
image

  1. Install 1.3.x. Enable Rewards.
    • Confirm Ads enabled by default
    • Confirm able to receive an Ad notification
    • Confirmed Ads panel info is updated as expected
    • Confirmed NTP widget is updated as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants