Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ads enabled by default on upgrade for new ad regions #7741

Closed
LaurenWags opened this issue Jan 15, 2020 · 4 comments · Fixed by brave/brave-core#4392
Closed

Ads enabled by default on upgrade for new ad regions #7741

LaurenWags opened this issue Jan 15, 2020 · 4 comments · Fixed by brave/brave-core#4392
Assignees
@tmancey
Labels
bug feature/ads priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude
Milestone
1.3.x - Release

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #6825

If a user in one of the new Ad regions from #6825 has Rewards enabled and upgrades from 1.2.42 to 1.3.x, there should be a BAT logo notification alerting the user that Ads are now available for their region. When the user goes to brave://rewards Ads should be OFF so that the user has to opt-in.

What is happening is that on upgrade to 1.3.x there is no BAT logo notification and Ads are enabled by default on upgrade. (this happened previously when new ad regions were added as well: #6449 which specifies Japan but also applies to all other regions added with that release version).

Steps to Reproduce

Set up to be in a new region (I tested below with Belgium and Russia)

  1. Install 1.2.42 release version for a new ads region from Additional phase of Brave Ads regions #6825.
  2. Enable Rewards, verify "Sorry" message on ads panel
  3. Upgrade to 1.3.x

Actual result:

  • no notification on BAT logo to enable Ads
  • Navigate to brave://rewards and Ads are enabled by default

Expected result:

  • notification on BAT logo to enable Ads
  • Navigate to brave://rewards and Ads are not enabled by default

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.3.92 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Версия 10.14.6 (Выпуск 18G103)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? probably
  • Can you reproduce this issue with the nightly channel? probably

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @tmancey @jsecretan @rebron @brave/legacy_qa
@LaurenWags LaurenWags added this to the 1.3.x - Beta milestone Jan 15, 2020
@LaurenWags LaurenWags mentioned this issue Jan 15, 2020
Closed
@jsecretan jsecretan added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 15, 2020
@tmancey tmancey self-assigned this Jan 17, 2020
This was referenced Jan 19, 2020
Merged
Merged
Merged
@tmancey tmancey changed the title ads enabled by default on upgrade for new ad regions Ads enabled by default on upgrade for new ad regions Jan 20, 2020
@tmancey tmancey added bug priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 20, 2020
@tmancey tmancey modified the milestones: 1.3.x - Beta, 1.5.x - Nightly Jan 23, 2020
@tmancey
Copy link
Contributor

tmancey commented Jan 23, 2020

@LaurenWags Merged with 1.5, so we can test on nightly, once tested can then request an uplift to 1.3 and 1.4 (as release blocking)

@tmancey tmancey modified the milestones: 1.5.x - Nightly, 1.3.x - Beta Jan 23, 2020
@kjozwiak
Copy link
Member

Removing QA/Blocked as both brave/brave-core#4393 and brave/brave-core#4394 have been merged. Once we get a new 1.3.x build that's > 1.3.100, QA should be able to verify this issue.

@kjozwiak
Copy link
Member

@brave/legacy_qa because @LaurenWags already ran through all the cases on Nightly via brave/brave-core#4392 (comment), please run through a few of the upgrade cases in 1.3.x due to time constraints. Maybe picking ~3 versions and ensuring those upgrades worked as expected.

@LaurenWags
Copy link
Member Author

LaurenWags commented Feb 3, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS macOS Version 10.14.6 (assemblage 18G103)

  1. Upgrade path for unsupported locale to supported locale

    • PASS Installed 1.0.1 for Belgium. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: ads were not enabled by default and there was a BAT logo notification notifying the user that Brave Ads are now available in their region.
    • PASS Installed 1.1.23 for Belgium. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: ads were not enabled by default and there was a BAT logo notification notifying the user that Brave Ads are now available in their region.
    • PASS Installed 1.2.43 for Belgium. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: ads were not enabled by default and there was a BAT logo notification notifying the user that Brave Ads are now available in their region.

  2. Upgrade path for unsupported locale to unsupported locale

    • PASS Installed 1.0.1 for Aruba. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: still see "Sorry" message and there is no BAT logo encouraging user to try Ads.
    • PASS Installed 1.1.23 for Aruba. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: still see "Sorry" message and there is no BAT logo encouraging user to try Ads.
    • PASS Installed 1.2.43 for Aruba. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: still see "Sorry" message and there is no BAT logo encouraging user to try Ads.

  3. Upgrade path for supported locale (with Ads enabled) to supported locale

    • PASS Installed 1.0.1 for US. Enabled Rewards and viewed an Ad. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: Ads still on after upgrade, Ads panel displays expected data, can still receive ad notifications.
    • PASS Installed 1.1.23 for US. Enabled Rewards and viewed an Ad. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: Ads still on after upgrade, Ads panel displays expected data, can still receive ad notifications.
    • PASS Installed 1.2.43 for US. Enabled Rewards and viewed an Ad. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: Ads still on after upgrade, Ads panel displays expected data, can still receive ad notifications.

Verification passed on

Brave 1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS Windows 10 OS Version 1803 (Build 17134.1006)

  1. Upgrade path for unsupported locale to supported locale

    • PASS Installed 1.0.1 for Belgium. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: ads were not enabled by default and there was a BAT logo notification notifying the user that Brave Ads are now available in their region.
    • PASS Installed 1.1.23 for Belgium. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: ads were not enabled by default and there was a BAT logo notification notifying the user that Brave Ads are now available in their region.
    • PASS Installed 1.2.43 for Belgium. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: ads were not enabled by default and there was a BAT logo notification notifying the user that Brave Ads are now available in their region.

  2. Upgrade path for unsupported locale to unsupported locale

    • PASS Installed 1.0.1 for Luxembourg. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: still see "Sorry" message and there is no BAT logo encouraging user to try Ads.
    • PASS Installed 1.1.23 for Luxembourg. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: still see "Sorry" message and there is no BAT logo encouraging user to try Ads.
    • PASS Installed 1.2.43 for Luxembourg. Enabled Rewards. Confirmed “Sorry” message on Ads panel. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: still see "Sorry" message and there is no BAT logo encouraging user to try Ads.

  3. Upgrade path for supported locale (with Ads enabled) to supported locale

    • PASS Installed 1.0.1 for Austalia. Enabled Rewards and viewed an Ad. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: Ads still on after upgrade, Ads panel displays expected data, can still receive ad notifications.
    • PASS Installed 1.1.23 for Austalia. Enabled Rewards and viewed an Ad. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: Ads still on after upgrade, Ads panel displays expected data, can still receive ad notifications.
    • PASS Installed 1.2.43 for Austalia. Enabled Rewards and viewed an Ad. Upgraded to 1.3.x (renamed profile). After upgrade worked as expected: Ads still on after upgrade, Ads panel displays expected data, can still receive ad notifications.

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Ubuntu 18.04 LTS

PASS Upgrade path for unsupported locale to unsupported locale - Luxemburg
Verified for upgrades from 1.0.1, 1.1.23, 1.2.43
Verified after upgrade worked as expected: still see "Sorry" message and there is no BAT logo encouraging user to try Ads.

PASS Upgrade path for supported locale (with Ads enabled) to supported locale - US
Verified for upgrades from 1.0.1, 1.1.23, 1.2.43
Verified after upgrade worked as expected: Ads still on after upgrade, Ads panel displays expected data, can still receive ad notifications.

@kjozwiak kjozwiak mentioned this issue Feb 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes ads enabled by default on upgrade of 1.2 to 1.3 for new ad regions brave/brave-core
6 participants
@jsecretan @tmancey @kjozwiak @LaurenWags @btlechowski @GeetaSarvadnya