Ads service will crash if a user previously had ads history and triggers OnUnIdle before Brave ads are initialized

[tmancey]

Description

Ads service will crash if a user previously had ads history and triggers OnUnIdle before Brave ads are initialized

Steps to Reproduce

1. View an ad
2. Quit the browser
3. Launch the browser
4. Wait for "Browser state changed to unidle" to appear in the console log
5. Move the mouse (this must occur before Brave ads are initialized)

Actual result:

Ads service crashes

Expected result:

Ads service should not crash

Reproduces how often:

Intermittent issue

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the dev channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

If the ads service crashes, it will restart. The browser will not crash

[btlechowski]

Verification passed on

Brave	1.3.50 Chromium: 79.0.3945.56 (Official Build) nightly (64-bit)
Revision	73cc6bf591f792b99f8fc7cdfb8addedbd084bf8-refs/branch-heads/3945@{#788}
OS	Ubuntu 18.04 LTS

I was unable to reproduce the issue. Verified test plan from the description. No crash.

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave	1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.15.2 (Build 19C57)

• Ensured that the browser doesn't crash when retrieving ads while Brave goes unidle

Verification passed on

Brave	1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Ensured that the browser doesn't crash when retrieving ads while Brave goes unidle

[kjozwiak]

Quickly talked to @tmancey and unfortunately there's no way to slow down ad initialization so Brave's state can change to unidle before initialization is completed.

So QA we'll basically make sure that retrieving ads doesn't crash/cause any issues.