Fixes ads service will crash if a user previously had ads history and triggers OnUnIdle before Brave ads are initialized #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
added
CI/skip-android
|
Windows failed CI so restarting Windows build |
tmancey
removed
CI/skip-android
masparrow
reviewed
Nov 12, 2019
| @@ -231,7 +231,7 @@ bool AdsImpl::IsInitialized() { | |||
| void AdsImpl::Shutdown( | |||
| ShutdownCallback callback) { | |||
| if (!is_initialized_) { | |||
| BLOG(WARNING) << "Failed to shutdown ads as not initialized"; | |||
| BLOG(WARNING) << "Shutdown failed as not initialized"; | |||
There was a problem hiding this comment.
Better as (INFO)? It's fair to say you can't shut something down if it's not initialised, so really this is just diagnostic at this point to say something called it prematurely?
There was a problem hiding this comment.
Our logs are quite busy as is, so wanted to reduce noise. When diagnosing issues we use a higher verbosity.
masparrow
reviewed
Nov 12, 2019
| @@ -342,6 +344,10 @@ void AdsImpl::OnUnIdle() { | |||
|
|
|||
| BLOG(INFO) << "Browser state changed to unidle"; | |||
|
|
|||
| if (!IsInitialized()) { | |||
| return; | |||
There was a problem hiding this comment.
BLOG here perhaps? Or superfluous?
There was a problem hiding this comment.
Good point, adding now
… triggers OnUnIdle before Brave ads are initialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#6880
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
See brave/brave-browser#6880 for steps
Reviewer Checklist:
After-merge Checklist:
changes has landed on.