Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion expiration #6947

Closed
NejcZdovc opened this issue Nov 15, 2019 · 1 comment · Fixed by brave/brave-core#4035
Closed

Promotion expiration #6947

NejcZdovc opened this issue Nov 15, 2019 · 1 comment · Fixed by brave/brave-core#4035
Assignees

Comments

@NejcZdovc
Copy link
Contributor

UGP promotions has expiration date so we need to handle it. Every time that we call fetch we need to go through list of promotions that we get from the db and check if any of it expired. If so we need to mark promotion is OVER and delete all unblinded tokes related to this promotion if any exists.

@NejcZdovc NejcZdovc added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 15, 2019
masparrow added a commit to brave/brave-core that referenced this issue Nov 20, 2019
@masparrow masparrow modified the milestone: 1.3.x - Nightly Nov 20, 2019
masparrow added a commit to brave/brave-core that referenced this issue Nov 27, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Dec 3, 2019
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Dec 3, 2019
gdregalo pushed a commit to brave/brave-core that referenced this issue Jan 10, 2020
@btlechowski
Copy link

btlechowski commented Jan 14, 2020

Verification passed on

Brave 1.3.90 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4035

image
image

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)

Before changing expires_at under promotion via publisher_info_db:

Screen Shot 2020-01-14 at 5 59 07 PM

After changing expires_at under promotion via publisher_info_db:

Screen Shot 2020-01-14 at 5 59 41 PM

Verification passed on

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment