Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden contribution flow #7201

Closed
NejcZdovc opened this issue Dec 4, 2019 · 4 comments · Fixed by brave/brave-core#4132
Closed

Harden contribution flow #7201

NejcZdovc opened this issue Dec 4, 2019 · 4 comments · Fixed by brave/brave-core#4132

Comments

@NejcZdovc
Copy link
Contributor

We got some reports that contribution flow is triggered multiple times where user only triggered it once.

So we should check multiple places:

  • contribution query
  • transaction retry
  • make sure that at no point we add new current reconcile to the list except if user/ac triggers it

Reports:

cc @Brave-Matt if you have any more reports about this one

@NejcZdovc NejcZdovc added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Dec 4, 2019
@NejcZdovc NejcZdovc self-assigned this Dec 4, 2019
@NejcZdovc NejcZdovc mentioned this issue Dec 5, 2019
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 5, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 6, 2019
@NejcZdovc NejcZdovc added this to the 1.4.x - Nightly milestone Dec 7, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jan 3, 2020

Removing QA/Blocked as this was merged into 1.2.x as per brave/brave-core#4285 and added into https://github.com/brave/brave-browser/releases/tag/v1.2.40.

@LaurenWags
Copy link
Member

LaurenWags commented Jan 3, 2020

Verified passed with

Brave 1.2.40 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)
  • Verified test plan from Ac spent brave-core#4132
  • Confirmed AC contributed as expected (wallet balance decreased accordingly, AC was recorded in wallet panel on brave://rewards)
  • Confirmed monthly recurring tips were contributed as expected (wallet balance decreased accordingly, tips were recorded in wallet panel on brave://rewards)
  • Confirmed one time tips were contributed as expected (wallet balance decreased accordingly, tips were recorded in wallet panel on brave://rewards)
  • Confirmed on both staging and prod environments

Verification passed on

Brave 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS
  • Verified test plan from Ac spent brave-core#4132
  • Confirmed AC contributed as expected (wallet balance decreased accordingly, AC was recorded in wallet panel on brave://rewards)
  • Confirmed monthly recurring tips were contributed as expected (wallet balance decreased accordingly, tips were recorded in wallet panel on brave://rewards)
  • Confirmed one time tips were contributed as expected (wallet balance decreased accordingly, tips were recorded in wallet panel on brave://rewards)
  • Confirmed on both staging and prod environments

image

Verification passed on

Brave 1.2.41 Chromium: 79.0.3945.88 (Official Build) (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified test plan from Ac spent brave-core#4132
  • Confirmed AC contributed as expected (wallet balance decreased accordingly, AC was recorded in wallet panel on brave://rewards)
  • Confirmed monthly recurring tips were contributed as expected (wallet balance decreased accordingly, tips were recorded in wallet panel on brave://rewards)
  • Confirmed one time tips were contributed as expected (wallet balance decreased accordingly, tips were recorded in wallet panel on brave://rewards)
  • Confirmed on both staging and prod environments
    image

@wizonesolutions
Copy link

Is there a way to fix excessive contribution retries one-time, basically to reset the number if it has gotten really high due to the old bug? Besides closing the popup. 9,000x :) Cc @NejcZdovc

@NejcZdovc
Copy link
Contributor Author

@wizonesolutions will fix it in #7239 to clear local storage. You will also need to do this step #6867 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants