Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes foreign keys from rewards database #7682

Closed
NejcZdovc opened this issue Jan 10, 2020 · 1 comment · Fixed by brave/brave-core#4354
Closed

Removes foreign keys from rewards database #7682

NejcZdovc opened this issue Jan 10, 2020 · 1 comment · Fixed by brave/brave-core#4354
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.5.x - Release

Comments

@NejcZdovc
Copy link
Contributor

Based on #7579 and talk with @bsclifton and @bbondy we decided to completely remove foreign keys and keep it simple.
@NejcZdovc NejcZdovc added this to the 1.5.x - Nightly milestone Jan 10, 2020
@NejcZdovc NejcZdovc self-assigned this Jan 10, 2020
@NejcZdovc NejcZdovc mentioned this issue Jan 10, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 10, 2020
@NejcZdovc
Removes foreign keys from all tables
638c99d 
brave/brave-browser#7682
@NejcZdovc NejcZdovc added QA/Yes and removed QA/No labels Jan 10, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Mar 3, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.5.106 Chromium: 80.0.3987.122 (Official Build) beta (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.14.6 (Build 18G3020)

Scenario 1:

  • Installed 1.0.0 and enabled Rewards
  • Restored a wallet with a balance
  • Viewed at least one ad, updated Ads panel settings
  • Set up AC table, had one AC go thru. Set up AC table again. Modified AC settings.
  • Set up recurring tip
  • Did a one time tip
  • Updated Tips panel settings
  • Set up pending tips to non-verified publishers
  • Updated to 1.5.x
  • Confirmed all data (settings updates, AC table, tips tables, pending tips, wallet balance, wallet summary items, etc) was intact

Scenario 2:

  • Installed 1.0.0 and enabled Rewards
  • Restored a wallet with a balance
  • Viewed at least one ad, updated Ads panel settings
  • Set up AC table, had one AC go thru. Set up AC table again. Toggled AC OFF.
  • Set up recurring tip
  • Did a one time tip
  • Updated Tips panel settings
  • Set up pending tips to non-verified publishers
  • Updated to 1.5.x
  • Confirmed all data (settings updates, tips tables, pending tips, wallet balance, wallet summary items, etc) was intact
  • Confirmed AC still toggled OFF
  • Confirmed AC did not occur (however recurring tip was contributed as expected)

Scenario 3:

  • Installed 1.0.0 and enabled Rewards
  • Toggle Ads OFF
  • Update to 1.5.x
  • Confirm Ads still toggled OFF

Scenario 4:

  • Installed 1.0.0 and enabled Rewards
  • Toggle Rewards OFF
  • Update to 1.5.x
  • Confirm Rewards still toggled OFF

Verification passed on

Brave 1.5.108 Chromium: 80.0.3987.132 (Official Build) beta (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Scenario 1:

  • Installed 1.0.0 and enabled Rewards
  • Restored a wallet with a balance
  • Viewed at least one ad, updated Ads panel settings
  • Set up AC table, had one AC go thru. Set up AC table again. Modified AC settings.
  • Set up recurring tip
  • Did a one time tip
  • Updated Tips panel settings
  • Set up pending tips to non-verified publishers
  • Updated to 1.5.x
  • Confirmed all data (settings updates, AC table, tips tables, pending tips, wallet balance, wallet summary items, etc) was intact

Scenario 2:

  • Installed 1.0.0 and enabled Rewards
  • Restored a wallet with a balance
  • Viewed at least one ad, updated Ads panel settings
  • Set up AC table, had one AC go thru. Set up AC table again. Toggled AC OFF.
  • Set up recurring tip
  • Did a one time tip
  • Updated Tips panel settings
  • Set up pending tips to non-verified publishers
  • Updated to 1.5.x
  • Confirmed all data (settings updates, tips tables, pending tips, wallet balance, wallet summary items, etc) was intact
  • Confirmed AC still toggled OFF
  • Confirmed AC did not occur (however recurring tip was contributed as expected)

Scenario 3:

  • Installed 1.0.0 and enabled Rewards
  • Toggle Ads OFF
  • Update to 1.5.x
  • Confirm Ads still toggled OFF

Scenario 4:

  • Installed 1.0.0 and enabled Rewards
  • Toggle Rewards OFF
  • Update to 1.5.x
  • Confirm Rewards still toggled OFF

Verification passed on

Brave 1.5.109 Chromium: 80.0.3987.132 (Official Build) beta (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS

Scenario 1:

  • Installed 1.0.0 and enabled Rewards
  • Restored a wallet with a balance
  • Viewed at least one ad, updated Ads panel settings
  • Set up AC table, had one AC go thru. Set up AC table again. Modified AC settings.
  • Set up recurring tip
  • Did a one time tip
  • Updated Tips panel settings
  • Set up pending tips to non-verified publishers
  • Updated to 1.5.x
  • Confirmed all data (settings updates, AC table, tips tables, pending tips, wallet balance, wallet summary items, etc) was intact

Scenario 2:

  • Installed 1.0.0 and enabled Rewards
  • Restored a wallet with a balance
  • Viewed at least one ad, updated Ads panel settings
  • Set up AC table, had one AC go thru. Set up AC table again. Toggled AC OFF.
  • Set up recurring tip
  • Did a one time tip
  • Updated Tips panel settings
  • Set up pending tips to non-verified publishers
  • Updated to 1.5.x
  • Confirmed all data (settings updates, tips tables, pending tips, wallet balance, wallet summary items, etc) was intact
  • Confirmed AC still toggled OFF
  • Confirmed AC did not occur (however recurring tip was contributed as expected)

Scenario 3:

  • Installed 1.0.0 and enabled Rewards
  • Toggle Ads OFF
  • Update to 1.5.x
  • Confirm Ads still toggled OFF

Scenario 4:

  • Installed 1.0.0 and enabled Rewards
  • Toggle Rewards OFF
  • Update to 1.5.x
  • Confirm Rewards still toggled OFF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.5.x - Release
Development

Successfully merging a pull request may close this issue.

Removes foreign keys brave/brave-core
4 participants
@NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya