Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application crashes when calculating the winning page classification category #7866

Closed
tmancey opened this issue Jan 22, 2020 · 3 comments · Fixed by brave/brave-core#4770
Closed

Comments

@tmancey
Copy link
Contributor

tmancey commented Jan 22, 2020

Description

Application crashes when calculating the winning page classification category to decide which ads to show to the user

Steps to Reproduce

  1. Change the OS locale to "United States"
  2. View a Brave Ad
  3. Quit the browser
  4. Change the OS locale to an untargeted locale (such as Denmark)
  5. Launch the browser
  6. View a Brave Ad

Actual result:

The application crashes when calculating the winning page classification category
Application crashes

Expected result:

The application should not crash when calculating the winning page classification category
Brave Ad should be shown and application should not crash

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. feature/ads labels Jan 22, 2020
@tmancey tmancey self-assigned this Jan 22, 2020
@tmancey tmancey added the QA/Yes label Jan 23, 2020
@rebron rebron added the crash label Feb 11, 2020
@tmancey
Copy link
Contributor Author

tmancey commented Feb 27, 2020

The issue has been reproduced on Android #8415 (comment), awaiting state files from @SergeyZhukovsky to reproduce

@tmancey
Copy link
Contributor Author

tmancey commented Feb 27, 2020

Raised this issue to fix crashes 4 and 7 for https://github.com/brave/browser-android-tabs/issues/2435

@tmancey tmancey changed the title Application intermittently crashes when calculating the winning page classification category Application crashes when calculating the winning page classification category Feb 27, 2020
@tmancey tmancey added this to the 1.7.x - Nightly milestone Feb 27, 2020
@tmancey tmancey added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 27, 2020
@kjozwiak kjozwiak removed this from the 1.7.x - Nightly milestone Mar 2, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 4, 2020

Verification passed on

Brave 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description

Verification passed on

Brave 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS
  • Verified test plan from the description

Verified passed with

Brave 1.4.96 Chromium: 80.0.3987.132 (Official Build) (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS macOS Version 10.14.6 (Build 18G3020)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants