Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes application crashes when calculating the winning page classification category - 1.5.x #4790

Merged
merged 1 commit into from
Mar 2, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Feb 28, 2020

Uplift of #4770
Resolves brave/brave-browser#7866

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.5.x - Beta milestone Feb 28, 2020
@tmancey tmancey requested a review from a team February 28, 2020 15:37
@tmancey tmancey self-assigned this Feb 28, 2020
@kjozwiak
Copy link
Member

Restarting macOS as test-unit and test-browser failed as per the following:

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux and removed PR/Pending Review labels Feb 29, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any failures. QA also went through the PR on Nightly as per #4770 (comment).

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 9c52ea6 into 1.5.x Mar 2, 2020
@kjozwiak kjozwiak deleted the issues/7866-1.5.x branch March 2, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants