Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop specific: Changes in non KYC Uphold user wallet state #8075

Closed
mandar-brave opened this issue Feb 5, 2020 · 1 comment · Fixed by brave/brave-core#4667
Closed
Assignees

Comments

@mandar-brave
Copy link

Issue: due to new regulations coming from Uphold - enforcement coming soon- specific to any withdrawals now need IDV or ID verification. This will require that any non ID checked (unverified) accounts used for tipping or contributions cannot tip or contribute anymore.

Fixes:

  • Remove support for such a state completely (numbers suggest its limited)
  • Show zero balance for such user wallets (they cannot be used for contributions)
  • Such wallets need to KYC/ID check to claim funds or contribute

This is now going to be the standard state support on BR going forward; User funds with ID checked wallet or anon wallets with Brave funds.

cc @NejcZdovc @jsecretan @evq

@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels Feb 5, 2020
@NejcZdovc NejcZdovc self-assigned this Feb 17, 2020
@NejcZdovc NejcZdovc added this to the 1.6.x - Nightly milestone Feb 17, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 17, 2020
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
jonathanKingston pushed a commit to jonathanKingston/brave-core that referenced this issue Mar 11, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Apr 2, 2020

Verified passed with

Brave 1.7.82 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS macOS Version 10.14.6 (Build 18G3020)

Clean profile test:

  1. Installed 1.7.82, enabled rewards
  2. Connected same acct from upgrade test (has a balance of 4 BAT on uphold)
    --> Confirmed balance displays 0 on brave://rewards and panel even though 4 BAT balance is available on Uphold
    --> Confirmed I do not see https://api-sandbox.uphold.com/v0/me/cards/"cardID" in terminal.
    --> Confirmed unable to tip same publisher I could with 1.5.115.

Upgrade test:

  1. Installed 1.5.115, enabled rewards
  2. Connected a non-KYC'd Uphold act
  3. Added BAT to Brave Browser card of non-KYC'd Uphold acct
  4. Confirmed balance updated in browser.
  5. Tipped 1 BAT to verified publisher (3zsistemi.si). Tip is deducted from balance and displays on brave://rewards and in panel summaries.
  6. Confirmed I do see https://api-sandbox.uphold.com/v0/me/cards/"cardID" in terminal.
  7. Upgraded to 1.7.82
    --> Confirmed balance displays 0 on brave://rewards and panel even though 4 BAT balance is available on Uphold
    --> Confirmed I do not see https://api-sandbox.uphold.com/v0/me/cards/"cardID" in terminal.
    --> Confirmed unable to tip same publisher I could with 1.5.115.

Screen Shot 2020-04-02 at 10 52 48 AM

Screen Shot 2020-04-02 at 10 52 58 AM

Screen Shot 2020-04-02 at 10 53 08 AM

Screen Shot 2020-04-02 at 10 55 17 AM

Verification passed on

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Clean profile test:

  1. Installed 1.7.82, enabled rewards
  2. Connected same acct from upgrade test (has a balance of 4 BAT on uphold)
    --> Confirmed balance displays 0 on brave://rewards and panel even though 4 BAT balance is available on Uphold
    --> Confirmed I do not see https://api-sandbox.uphold.com/v0/me/cards/"cardID" in terminal.
    --> Confirmed unable to tip same publisher I could with 1.5.115.

Upgrade test:

  1. Installed 1.5.115, enabled rewards
  2. Connected a non-KYC'd Uphold act
  3. Added BAT to Brave Browser card of non-KYC'd Uphold acct
  4. Confirmed balance updated in browser.
  5. Tipped 1 BAT to verified publisher (3zsistemi.si). Tip is deducted from balance and displays on brave://rewards and in panel summaries.
  6. Confirmed I do see https://api-sandbox.uphold.com/v0/me/cards/"cardID" in terminal.
  7. Upgraded to 1.7.82
    --> Confirmed balance displays 0 on brave://rewards and panel even though 4 BAT balance is available on Uphold
    --> Confirmed I do not see https://api-sandbox.uphold.com/v0/me/cards/"cardID" in terminal.
    --> Confirmed unable to tip same publisher I could with 1.5.115.

image
image

image
image

Verification passed on

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Ubuntu 18.04 LTS

Clean profile test:

  1. Installed 1.7.82, enabled rewards
  2. Connected same acct from upgrade test (has a balance of 4 BAT on uphold)
    --> Confirmed balance displays 0 on brave://rewards and panel even though 4 BAT balance is available on Uphold
    --> Confirmed I do not see https://api-sandbox.uphold.com/v0/me/cards/"cardID" in terminal.
    --> Confirmed unable to tip same publisher I could with 1.5.115.

Upgrade test:

  1. Installed 1.5.115, enabled rewards
  2. Connected a non-KYC'd Uphold act
  3. Added BAT to Brave Browser card of non-KYC'd Uphold acct
  4. Confirmed balance updated in browser.
  5. Tipped 1 BAT to verified publisher (3zsistemi.si). Tip is deducted from balance and displays on brave://rewards and in panel summaries.
  6. Confirmed I do see https://api-sandbox.uphold.com/v0/me/cards/"cardID" in terminal.
  7. Upgraded to 1.7.82
    --> Confirmed balance displays 0 on brave://rewards and panel even though 4 BAT balance is available on Uphold
    --> Confirmed I do not see https://api-sandbox.uphold.com/v0/me/cards/"cardID" in terminal.
    --> Confirmed unable to tip same publisher I could with 1.5.115.

image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants