"BraveAppMenuBrowserTest.BasicTest" failing when running "test-browser" on "1.3.x"

[kjozwiak]

Description

We need to fix the BraveAppMenuBrowserTest.BasicTest test that's currently failing on 1.3.x.

• Linux - https://ci.brave.com/job/brave-browser-build-pr/job/pr4536_disable-sync-switch_1.3.x/3/execution/node/463/log/
• macOS - https://ci.brave.com/job/brave-browser-build-pr/job/pr4536_disable-sync-switch_1.3.x/3/execution/node/493/log/

Steps to Reproduce

Run through CI on 1.3.x and you'll notice that BraveAppMenuBrowserTest.BasicTest is failing.

Actual result:

02:48:44  [ RUN      ] BraveAppMenuBrowserTest.BasicTest
02:48:44  Xlib:  extension "XInputExtension" missing on display ":3".
02:48:44  Xlib:  extension "XInputExtension" missing on display ":3".
02:48:44  Xlib:  extension "XInputExtension" missing on display ":3".
02:48:44  Xlib:  extension "XInputExtension" missing on display ":3".
02:48:44  [22986:23035:0209/074844.206687:ERROR:bus.cc(393)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
02:48:44  [22986:23035:0209/074844.219695:ERROR:bus.cc(393)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
02:48:44  [22986:23035:0209/074844.219716:ERROR:bus.cc(393)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
02:48:44  Xlib:  extension "XInputExtension" missing on display ":3".
02:48:44  Xlib:  extension "XInputExtension" missing on display ":3".
02:48:44  [22986:23016:0209/074844.280890:ERROR:rewards_service_impl.cc(206)] Failed to read file: /tmp/.org.chromium.Chromium.59dqQ7/user_data/Default/ledger_state
02:48:44  [23043:23043:0209/074844.285414:ERROR:ledger_impl.cc(102)] Failed to initialize wallet
02:48:44  ../../brave/browser/ui/toolbar/brave_app_menu_model_browsertest.cc:67: Failure
02:48:44  Value of: command_controller->IsCommandEnabled(IDC_SHOW_BRAVE_SYNC)
02:48:44    Actual: false
02:48:44  Expected: true
02:48:44  Stack trace:
02:48:44  #0 0x562a694d9059 (/home/ubuntu/jenkins/workspace/pr4536_disable-sync-switch_1.3.x/src/out/Release/brave_browser_tests+0x4f20058)
02:48:44  
02:48:44  ../../brave/browser/ui/toolbar/brave_app_menu_model_browsertest.cc:98: Failure
02:48:44  Value of: command_controller->IsCommandEnabled(IDC_SHOW_BRAVE_SYNC)
02:48:44    Actual: false
02:48:44  Expected: true
02:48:44  Stack trace:
02:48:44  #0 0x562a694d9059 (/home/ubuntu/jenkins/workspace/pr4536_disable-sync-switch_1.3.x/src/out/Release/brave_browser_tests+0x4f20058)
02:48:44  
02:48:44  [22986:22986:0209/074844.350402:ERROR:brave_new_tab_message_handler.cc(126)] Ads service is not initialized!
02:48:44  [22986:23014:0209/074844.364735:ERROR:rewards_service_impl.cc(206)] Failed to read file: /tmp/.org.chromium.Chromium.59dqQ7/user_data/Guest Profile/ledger_state
02:48:44  [23043:23043:0209/074844.368857:ERROR:ledger_impl.cc(102)] Failed to initialize wallet
02:48:44  [  FAILED  ] BraveAppMenuBrowserTest.BasicTest, where TypeParam =  and GetParam() =  (1163 ms)
02:48:44  [460/468] BraveAppMenuBrowserTest.BasicTest (1306 ms)
02:48:54  [461/468] BraveRewardsBrowserTest.TipUnverifiedPublisher (8385 ms)
02:49:02  [462/468] BraveRewardsBrowserTest.RecurringTipForVerifiedPublisher (8910 ms)
02:49:17  Still waiting for the following processes to finish:
02:49:17  	/home/ubuntu/jenkins/workspace/pr4536_disable-sync-switch_1.3.x/src/out/Release/brave_browser_tests --disable-gpu-process-for-dx12-vulkan-info-collection --enable-logging --gtest_also_run_disabled_tests --gtest_filter=BraveRewardsBrowserTest.ProcessPendingContributions --single-process-tests --test-launcher-output=/tmp/.org.chromium.Chromium.BsPDXL/resultsZjxDzw/test_results.xml --user-data-dir=/tmp/.org.chromium.Chromium.BsPDXL/user_data --v=0
02:49:32  Still waiting for the following processes to finish:
02:49:32  	/home/ubuntu/jenkins/workspace/pr4536_disable-sync-switch_1.3.x/src/out/Release/brave_browser_tests --disable-gpu-process-for-dx12-vulkan-info-collection --enable-logging --gtest_also_run_disabled_tests --gtest_filter=BraveRewardsBrowserTest.ProcessPendingContributions --single-process-tests --test-launcher-output=/tmp/.org.chromium.Chromium.BsPDXL/resultsZjxDzw/test_results.xml --user-data-dir=/tmp/.org.chromium.Chromium.BsPDXL/user_data --v=0
02:49:36  [463/468] BraveRewardsBrowserTest.ProcessPendingContributions (34344 ms)
02:49:43  [464/468] BraveRewardsBrowserTest.SiteBannerDefaultTipChoices (5763 ms)
02:49:48  [465/468] BraveRewardsBrowserTest.TipWithVerifiedWallet (5763 ms)
02:49:56  [466/468] BraveRewardsBrowserTest.TipConnectedPublisherAnon (7861 ms)
02:50:01  [467/468] BraveRewardsBrowserTest.TipConnectedPublisherVerified (6026 ms)
02:50:03  [468/468] BraveRewardsBrowserTest.ShowMonthlyIfACOff (1830 ms)
02:50:03  1 test failed:
02:50:03      BraveAppMenuBrowserTest.BasicTest (../../brave/browser/ui/toolbar/brave_app_menu_model_browsertest.cc:34)

Expected result:

BraveAppMenuBrowserTest.BasicTest shouldn't be failing when running through test-browser

Reproduces how often:

100% reproducible when running through CI on 1.3.x

Brave version (brave://version info)

When running through CI on the 1.3.x channel (release).

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the dev channel? No
• Can you reproduce this issue with the nightly channel? No

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @darkdh @bbondy @rebron @bsclifton