Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UI suffix from methods #8161

Closed
NejcZdovc opened this issue Feb 10, 2020 · 0 comments · Fixed by brave/brave-core#5246
Closed

Remove UI suffix from methods #8161

NejcZdovc opened this issue Feb 10, 2020 · 0 comments · Fixed by brave/brave-core#5246
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards QA/No release-notes/exclude
Milestone
1.10.x - Release

Comments

@NejcZdovc
Copy link
Contributor

Right now some functions in rewards service has UI appended to the name. This was added as we have db in implementation. With #6363 DB will be in shared lib, so we can refactor and remove this suffix.
@NejcZdovc NejcZdovc self-assigned this Apr 14, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 14, 2020
@NejcZdovc
Removes UI suffix from rewards service as we don't need it anymore
f97988b 
Resolves brave/brave-browser#8161
@NejcZdovc NejcZdovc mentioned this issue Apr 14, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added this to the 1.9.x - Nightly milestone Apr 14, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 22, 2020
@NejcZdovc
Removes UI suffix from rewards service as we don't need it anymore
26d3a5c 
Resolves brave/brave-browser#8161
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards QA/No release-notes/exclude
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging a pull request may close this issue.

Removes UI suffix from rewards service as we don't need it anymore brave/brave-core
2 participants
@rebron @NejcZdovc