Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P3A] Sent status is not recorded on upgrade [Follow up to #8084] #8295

Closed
srirambv opened this issue Feb 18, 2020 · 8 comments
Closed

[P3A] Sent status is not recorded on upgrade [Follow up to #8084] #8295

srirambv opened this issue Feb 18, 2020 · 8 comments

Comments

@srirambv
Copy link
Contributor

Description

[P3A] Sent status is not recorded on upgrade [Follow up to #8084]

Steps to Reproduce

  1. Clean profile 1.3.115
  2. Open brave://local-state
  3. Check P3A stats, sent is false no timestamp is recorded for all stats
  4. Upgrade to 1.3.116
  5. Close brave and launch using brave-browser --p3a-rotation-interval-seconds=5

Actual result:

Sent value is not updated

Expected result:

Sent value should be updated

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

Issue reproduced by @GeetaSarvadnya
cc: @iefremov @rebron

@GeetaSarvadnya
Copy link

Reproduced in windows 10 x64 - 1.3.116

@iefremov
Copy link
Contributor

there is a backoff delay right after the browser start. For how long have you been waiting? @GeetaSarvadnya

@GeetaSarvadnya
Copy link

@iefremov I have waited for almost 2 mins after the browser restart

@iefremov
Copy link
Contributor

ah, sorry, this is probably because of the wrong flag. No just restart browser without --p3a-rotation-interval-seconds=5. It doesn't let you actually send any data. I specified it in order to clean the sent state

@GeetaSarvadnya
Copy link

@iefremov @srirambv after upgrade without using the flag --p3a-rotation-interval-seconds=5. I am getting the expected results.
image

@iefremov
Copy link
Contributor

Thank you @GeetaSarvadnya

@srirambv
Copy link
Contributor Author

Confirmed working on Linux as well when browser is launched without the command line args
image

@srirambv
Copy link
Contributor Author

Working as expected hence closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants