Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking offsite links in pinned tab should always open a new tab #882

Closed
bsclifton opened this issue Aug 30, 2018 · 3 comments
Closed

Clicking offsite links in pinned tab should always open a new tab #882

bsclifton opened this issue Aug 30, 2018 · 3 comments
Labels
bug closed/duplicate Issue has already been reported feature/pinned-tabs

Comments

@bsclifton
Copy link
Member

Carried over from brave/browser-laptop#569

When I pin a tab, I want links to other sites to open in a new tab and only on-site links to open in the pinned tab. For example, if I pin gmail, I want to be able to navigate around gmail in that pinned tab but I want a link in an email to some other site to open in a new tab.

Steps to reproduce

  1. Visit https://media.clifton.io/issue-569/2016-05-27-brave-pin.html
  2. Pin the site
  3. Click the "same domain" link, notice it works as expected (opens in same tab)
  4. Click back
  5. Click the "external link"
  6. Notice it didn't work; it opens in the same tab
@bsclifton bsclifton added this to the Backlog milestone Aug 30, 2018
@bsclifton bsclifton mentioned this issue Aug 30, 2018
Closed
@srirambv
Copy link
Contributor

Its the same behaviour on Chrome as well. Not really sure if this bug was even valid for b-l as well.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@LaurenWags
Copy link
Member

+1 from my husband

@bsclifton bsclifton mentioned this issue Dec 17, 2019
Open
@bsclifton
Copy link
Member Author

Closing in favor of #7423

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Dec 17, 2019
@dayfuaim dayfuaim mentioned this issue Feb 15, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Feb 17, 2020
Closed
This was referenced Feb 17, 2020
Closed
Closed
Closed
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Feb 18, 2020
Closed
@srirambv srirambv mentioned this issue Feb 18, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 18, 2020
Closed
@hugobuddel hugobuddel mentioned this issue Feb 18, 2020
Closed
@srirambv srirambv mentioned this issue Feb 18, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 18, 2020
Closed
@srirambv srirambv mentioned this issue Feb 18, 2020
Closed
This was referenced Feb 18, 2020
Closed
Closed
Closed
This was referenced Feb 18, 2020
Closed
Closed
@srirambv srirambv mentioned this issue Feb 18, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Feb 18, 2020
Closed
This was referenced Feb 18, 2020
Closed
Closed
@snyk-bot snyk-bot mentioned this issue Jan 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug closed/duplicate Issue has already been reported feature/pinned-tabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bsclifton @rebron @srirambv @LaurenWags