Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shields settings] order and relabel cookies and fingerprinting dropdown items from block most to block least #8306

Closed
karenkliu opened this issue Feb 18, 2020 · 3 comments
Closed

[Shields settings] order and relabel cookies and fingerprinting dropdown items from block most to block least #8306

karenkliu opened this issue Feb 18, 2020 · 3 comments
Labels
closed/duplicate Issue has already been reported feature/shields The overall Shields feature in Brave. l10n needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@karenkliu
Copy link

Description

The dropdown items for blocking cookies and fingerprinting in Shields should be ordered from block most to block least options.

Steps to Reproduce

  1. Open Shields
  2. Click on the dropdown element for cookies or fingerprinting

Actual result:

Screen Shot 2020-02-18 at 11 14 13 AM

Screen Shot 2020-02-18 at 11 14 18 AM

Expected result:

Menu items should be ordered from block most to block least options like so:

Cookies:

Screen Shot 2020-02-18 at 11 16 46 AM

Fingeprinting:

Screen Shot 2020-02-18 at 11 16 43 AM

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

All versions
@karenkliu karenkliu mentioned this issue Feb 18, 2020
Merged
32 tasks
@rebron rebron added the feature/shields The overall Shields feature in Brave. label Apr 17, 2020
@rebron rebron added needs-text-change This change requires some careful wording. l10n priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 17, 2020
@rebron
Copy link
Collaborator

rebron commented Apr 17, 2020

@tomlowenthal Are you ok with these text changes?
cc: @cezaraugusto To put on your radar.

@rebron rebron changed the title Order Shields cookies and fingerprinting dropdown items from block most to block least in Shields settings, order and relabel cookies and fingerprinting dropdown items from block most to block least Apr 17, 2020
@rebron rebron changed the title in Shields settings, order and relabel cookies and fingerprinting dropdown items from block most to block least [Shields settings] order and relabel cookies and fingerprinting dropdown items from block most to block least Apr 17, 2020
@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Apr 17, 2020
@karenkliu
Copy link
Author

Fingerprinting options should use the list here that includes farbling #9194

@cezaraugusto cezaraugusto self-assigned this May 5, 2020
@cezaraugusto cezaraugusto removed their assignment May 18, 2020
@karenkliu
Copy link
Author

This has been fixed with #9975

@bsclifton bsclifton added the closed/duplicate Issue has already been reported label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported feature/shields The overall Shields feature in Brave. l10n needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. needs-text-change This change requires some careful wording. priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tildelowengrimm @karenkliu @cezaraugusto @bsclifton @rebron