Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shields: Reword "device recognition" as "fingerprint" #4574

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Conversation

cezaraugusto
Copy link
Contributor

Close brave/brave-browser#7949

Areas changed by this commit are Shields settings and Shields panel

Shields panel open
Screen Shot 2020-02-10 at 12 22 00 PM

brave://settings/shields
Screen Shot 2020-02-10 at 12 21 26 PM

Submitter Checklist:

Test Plan:

Ensure referenced areas have the word "fingerprint" replacing "device recognition".

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Close brave/brave-browser#7949

Areas changed by this commit are Shields settings and Shields panel
@karenkliu
Copy link

@cezaraugusto The menu items should appear in this order and be this text:

Screen Shot 2020-02-11 at 2 48 02 PM

Also while you're fixing this, can you make the cookies options follow the same ordering (block most to block least options):
Screen Shot 2020-02-11 at 2 48 41 PM

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, CI also looks good 👍

@bsclifton bsclifton merged commit f54785b into master Feb 18, 2020
@bsclifton bsclifton deleted the ca-7949 branch February 18, 2020 18:15
@bsclifton
Copy link
Member

@karenkliu can you create a separate issue for that? This PR (and the issue it solves) are just for renaming 😄

@karenkliu
Copy link

@bsclifton Done! brave/brave-browser#8306

@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Device recognition" label to "Fingerprint"
4 participants