[Dektop] Add Brave app automatically to Full Disk Access panel for macOS

[simonhong]

After merging brave/brave-core#4530, brave isn't added that panel automatically.
In that PR, it checks safari folder permission by using PathIsWritable().
Maybe other file access api like open could add automatically.

STR:

1. Remove brave from full disk accessed list
2. Launch brave and import safari
3. Check full disk access required dialog
4. Check brave is automatically added in full disk accessed list candidate with not checked state.

[rebron]

For context to add Brave into the panel: brave/brave-core#4530 (comment)

[kjozwiak]

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.15.5 (Build 19F101)

• went through the STR/Cases outlined via [Dektop] Add Brave app automatically to Full Disk Access panel for macOS #8343 (comment)
• verified that once you select Import when importing from Safari, Brave is added into Full Disk Access but not selected
• ensured that selecting Open System Preferences correctly opens Security & Privacy
• ensured that selecting Cancel closes the modal and doesn't open Security & Privacy
  • ensured that when cancelling, Brave is still added into Full Disk Access but not selected
• ensured that import from Safari works from once Full Disk Access is given to Brave
  • ensured that both History & Bookmarks/Favourites were being imported

[LaurenWags]

Using Mojave 10.14.6 the test plan from the description is not working for me.

Steps:

1. Navigated to System Prefs > Security & Privacy > Privacy and confirmed Brave Browser Dev was not in the list. Closed System Prefs.
2. Clean profile w/ 1.11.x
3. Opened brave://settings/importData (Safari is default) and clicked on Import
4. Got the popup as expected:

5. Clicked on Open System Preferences.
6. System Prefs was opened but Brave Browser Dev was not in the list automatically, although I could add it manually.

Brave | 1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

[kjozwiak]

@rebron @simonhong could someone check to see if the above works for you on Catalina? @simonhong do you know if the above fix should also be working on Mojave or is this only for >=Catalina?

@simonhong let me know if the above fix is possible on Mojave. I think we should be fine though but can always create a follow up and label it as P4. Once Big Sur gets released, Mojave market share will probably be pretty low. CCing @rebron @bsclifton on thoughts.

Going to label this as QA/Pass as #8343 (comment) isn't a blocker IMO.

[simonhong]

@kjozwiak This works on my local macOS(Catalina).
This was fixed indirectly by using OS-version independent file open API. If application tries to open some files/folders that needs full disk access permission, catalina seems to add that application to the list automatically.
I think this behavior could be dependent on os version.