Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single word keywords does not increase purchase intent when searching #8942

Closed
btlechowski opened this issue Mar 31, 2020 · 4 comments · Fixed by brave/brave-core#5182
Closed

Comments

@btlechowski
Copy link

Follow up to #8047

Searching for audi does not increase purchase intent

Steps to Reproduce

  1. Clean profile
  2. Connect to US
  3. Run Brave with command line: /usr/bin/brave-browser --enable-logging=stderr --vmodule=brave_ads=3 --brave-ads-staging --rewards=staging=true
  4. Enable Rewards
  5. Search for audi in URL bar

Actual result:

purchase intent weight is not increased
automotive purchase intent by make-audi in Default/ads_service/client.json is empty or doesn't exists

Expected result:

purchase intent weight is increased
automotive purchase intent by make-audi in Default/ads_service/client.json is not empty and contains one element

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.7.78 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @tmancey @moritzhaller

@btlechowski
Copy link
Author

@moritzhaller Is this PR merged in 1.9.x? Can you double check?

The issue is still reproducible on

Brave 1.9.55 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Linux

@moritzhaller
Copy link

@moritzhaller Is this PR merged in 1.9.x? Can you double check?

@btlechowski apologies, I tagged the wrong release it should be in 1.10.x!

@btlechowski
Copy link
Author

Changed the milestone to 1.10.x

@btlechowski
Copy link
Author

btlechowski commented May 28, 2020

Verification passed on

Brave 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5182

Searched for audi

"purchaseIntentSignalHistory": {
	"automotive purchase intent by make-audi": [{
			"timestamp_in_seconds": 1590649595,
			"weight": 1
		}
	]
},

Searched for acura

"automotive purchase intent by make-acura": [{
		"timestamp_in_seconds": 1590649955,
		"weight": 1
	}
],

Verification passed on


Brave | 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Searched for audi

"purchaseIntentSignalHistory": {
    "automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1590663220,
        "weight": 1
      }
    ]
  },

Verified passed with

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  "purchaseIntentSignalHistory": {
    "automotive purchase intent by make-audi": [
      {
        "timestamp_in_seconds": 1591039915,
        "weight": 1
      }
    ]
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment