Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Brave Payment features about:rewards #16

Closed
bbondy opened this issue Dec 5, 2017 · 2 comments · Fixed by brave/brave-core#241
Closed

Support Brave Payment features about:rewards #16

bbondy opened this issue Dec 5, 2017 · 2 comments · Fixed by brave/brave-core#241
Assignees
@NejcZdovc
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Dec 5, 2017

Add parity Brave features to what is in browser-laptop. Determine what we need above and beyond #15. We will likely move this to a new tab instead.
@bbondy bbondy added this to the Milestone 1: To be able to open source the repo milestone Dec 5, 2017
@bbondy bbondy changed the title Support Brave Payment features in a popup window Support Brave Payment features about:payments Mar 19, 2018
@bbondy bbondy modified the milestones: Milestone 1: To be able to open source the repo, Milestone 2: To offer Installable and updatable builds Mar 19, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #16 from brave/windows_build
0fab72b 
Windows Branding Fix
@bsclifton
Copy link
Member

bsclifton commented May 18, 2018 •
edited
Loading

I think we'll likely want to use about:rewards instead

The about:payments page (which we can rename) has been stubbed out with brave/brave-core@a8409b6

@NejcZdovc NejcZdovc self-assigned this May 18, 2018
@bbondy bbondy modified the milestones: Milestone 2: To offer Installable and updatable builds, Milestone 3: June-July Jun 6, 2018
@bbondy bbondy mentioned this issue Jun 14, 2018
Closed
@bbondy bbondy changed the title Support Brave Payment features about:payments Support Brave Payment features about:rewards Aug 16, 2018
@NejcZdovc NejcZdovc mentioned this issue Sep 2, 2018
Merged
@bbondy bbondy added the QA/Yes label Sep 10, 2018
@srirambv
Copy link
Contributor

srirambv commented Sep 20, 2018 •
edited by btlechowski
Loading

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Able to load rewards page by navigating directly to chrome://rewards
  • Able to load rewards page from hamburger menu

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
  • Loaded rewards by navigating directly to chrome://rewards
  • Loaded rewards by navigating directly to about://rewards
  • Loaded rewards by using the hamburger menu and selecting Brave Rewards

Verification passes on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

This was referenced Mar 18, 2020
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Mar 30, 2020
Closed
@btlechowski btlechowski mentioned this issue Mar 30, 2020
Closed
This was referenced Mar 31, 2020
Closed
Closed
Closed
Closed
This was referenced Mar 31, 2020
Closed
Closed
Closed
This was referenced Mar 31, 2020
Closed
Closed
@btlechowski btlechowski mentioned this issue Apr 1, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Apr 1, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Apr 1, 2020
Closed
@domdfcoding domdfcoding mentioned this issue Apr 1, 2020
Closed
This was referenced Apr 1, 2020
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Apr 1, 2020
Closed
@btlechowski btlechowski mentioned this issue Apr 1, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Apr 1, 2020
Closed
This was referenced Apr 1, 2020
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Apr 1, 2020
Closed
@afonsojramos afonsojramos mentioned this issue Apr 3, 2020
Closed
@LaurenWags LaurenWags mentioned this issue Apr 4, 2020
Closed
@iefremov iefremov mentioned this issue Nov 27, 2020
Closed
@wildcard-f8 wildcard-f8 mentioned this issue Dec 19, 2021
Closed
@tmancey tmancey mentioned this issue Feb 22, 2022
Closed
@bridiver bridiver mentioned this issue Mar 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Add rewards parity with browser laptop brave/brave-core
6 participants
@bbondy @kjozwiak @bsclifton @NejcZdovc @srirambv @btlechowski