Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UGP Token grants claimed value is 0.0 BAT in Monthly Statement #8961

Closed
GeetaSarvadnya opened this issue Apr 1, 2020 · 5 comments
Closed
Assignees
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 1, 2020

Description

Token grants claimed value is 0.0 BAT in Monthly Statement

Steps to Reproduce

  1. claim UGP grant
  2. claim Ad grant
  3. set up & perform AC
  4. set up & perform recurring tips
  5. set up 1-time tips
  6. Trigger AC and verify the monthly statement
  7. Token grants claimed value is 0.0 BAT in Monthly Statement

Actual result:

Token grants claimed value is 0.0 BAT in Monthly Statement
image

Expected result:

Token grants claimed value should show 20 BAT in Monthly Statement

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @rebron

@LaurenWags
Copy link
Member

Does not reproduce on macOS

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-04-01 at 8 09 26 AM

Did not encounter this when testing on 1.7.79 either.

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya do you see 0 on rewards page as well?

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Apr 3, 2020

@NejcZdovc In Rewards settings page Token grants claimed isn't displayed. when I expand Detail I can see token grants claimed. Also, I observed one more thing, after claiming UGP grants the wallet balance is reflected as 20 BAT when I restore ad grants the I get ad grants notification at the same time wallet balance turns to zero from 20 BAT. After claiming ad grants wallet balance shows both amounts (UGP+Ad grants) = 25. Please find the steps below:

  1. Clean profile ( use staging flag)
  2. Claim UGP grants
  3. Wallet balance is 20 BAT and Token grants claimed = 20BAT in rewards setting page
  4. Restore ad grants
  5. wallet restored 0 message is shown in wallet balance and Ad grants with claim button notification is shown in the rewards settings page
  6. Claim ad grants
  7. wallet balance shows 0 for few seconds and then it shows 25 BAT
  8. In rewards setting page now only Earning from ads is showing as 5 BAT there is no entry for Token grants claimed = 20BAT
  9. Open monthly statement - token grants claimed is 0 (shown in 1st two images below )

I can reproduce this issue consistently.

image
image

image
image

@NejcZdovc
Copy link
Contributor

@GeetaSarvadnya ok key thing is that you restored a wallet. When you do this summary is automatically cleared.

@mandar-brave we need to talk about this use case. What data should be removed when you restore a wallet? Right now we have a mix. We delete summary data that are store in json, but we keep db data

@NejcZdovc NejcZdovc removed this from the 1.7.x - Release milestone Apr 3, 2020
@NejcZdovc NejcZdovc added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Apr 3, 2020
@GeetaSarvadnya
Copy link
Author

Reproduced in Windows 10 x64 - 1.24.65

@Miyayes Miyayes changed the title Token grants claimed value is 0.0 BAT in Monthly Statement UGP Token grants claimed value is 0.0 BAT in Monthly Statement May 18, 2022
@Miyayes Miyayes added the priority/P4 Planned work. We expect to get to it "soon". label May 18, 2022
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

6 participants