Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Clicking Brave Shields button on a New Tab leaves button on a clicked state #9015

Closed
afonsojramos opened this issue Apr 3, 2020 · 4 comments
Labels
closed/by-author feature/new-tab feature/shields The overall Shields feature in Brave. OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@afonsojramos
Copy link

afonsojramos commented Apr 3, 2020

Description

When clicking the Brave Shields button while on a New Tab, the button stays on a clicked state, which persists even after changing tabs.

Steps to Reproduce

  1. Open New Tab
  2. Click Brave Shields button
  3. Change tabs to observe Brave Shields button remaining on a clicked state

Actual result:

image

Expected result:

image

Reproduces how often:

Easy to reproduce. Always happens.

Brave version (brave://version info)

Brave 1.5.115 Chromium: 80.0.3987.149 (Official Build) (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1909 (Build 18363.720)
@rebron
Copy link
Collaborator

rebron commented May 22, 2020

@afonsojramos Can you try this again on 1.9.72 our latest version from yesterday? On a New Tab Page, shields should actually be disabled as it's an internal page plus and doesn't apply there, so icon should be orange and there should be a number displayed.

@rebron rebron added feature/shields The overall Shields feature in Brave. feature/new-tab OS/Desktop needs-more-info The report requires more detail before we can decide what to do with this issue. labels May 22, 2020
@afonsojramos
Copy link
Author

afonsojramos commented May 23, 2020

Thanks! I'll try it as soon as sync is back thought, as I need the feature too much to live without it!

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label May 26, 2020
@rebron rebron removed the needs-more-info The report requires more detail before we can decide what to do with this issue. label May 26, 2020
@bsclifton
Copy link
Member

Looks like this happens still - but @afonsojramos we do have sync now 😄

@srirambv srirambv changed the title Clicking Brave Shields button on a New Tab leaves button on a clicked state [Desktop] Clicking Brave Shields button on a New Tab leaves button on a clicked state Sep 9, 2020
@afonsojramos
Copy link
Author

This seems to be now fixed, thanks! After 1 year and a half, I've now moved back to brave! 😁

PS: I left because of the lack of proper sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/by-author feature/new-tab feature/shields The overall Shields feature in Brave. OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

4 participants